[v1] Fix rpath handling in OCaml's Makefile.rules

[PATCH v1 0/1] Fix rpath handling in OCaml's Makefile.rules

Andrii Sultanov posted 1 patch 10 months, 3 weeks ago

Diff against v2
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/cover.1733757256.git.andrii.sultanov@cloud.com

There is a newer version of this series

tools/ocaml/Makefile.rules | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH v1 0/1] Fix rpath handling in OCaml's Makefile.rules

Posted by Andrii Sultanov 10 months, 3 weeks ago

As reported by Nix's Xen team, OCaml stub libs would embed an absolute
rpath in the binaries, which was picked up on by patchelf. This is a
symptom of improper handling of -rpath-link in the first place, so
correct that and get rid of the issue.

Andrii Sultanov (1):
  tools/ocaml: Specify rpath correctly for ocamlmklib

 tools/ocaml/Makefile.rules | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.39.5

Re: [PATCH v1 0/1] Fix rpath handling in OCaml's Makefile.rules

Posted by Andrii Sultanov 10 months, 3 weeks ago

DO NOT COMMIT - this patch is not correct, and I will send an updated
version later.

On Mon, Dec 9, 2024 at 3:16 PM Andrii Sultanov <andrii.sultanov@cloud.com>
wrote:

> As reported by Nix's Xen team, OCaml stub libs would embed an absolute
> rpath in the binaries, which was picked up on by patchelf. This is a
> symptom of improper handling of -rpath-link in the first place, so
> correct that and get rid of the issue.
>
> Andrii Sultanov (1):
>   tools/ocaml: Specify rpath correctly for ocamlmklib
>
>  tools/ocaml/Makefile.rules | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> --
> 2.39.5
>
>

Re: [PATCH v1 0/1] Fix rpath handling in OCaml's Makefile.rules

Posted by Christian Lindig 10 months, 3 weeks ago


> On 9 Dec 2024, at 15:16, Andrii Sultanov <andrii.sultanov@cloud.com> wrote:
> 
> As reported by Nix's Xen team, OCaml stub libs would embed an absolute
> rpath in the binaries, which was picked up on by patchelf. This is a
> symptom of improper handling of -rpath-link in the first place, so
> correct that and get rid of the issue.
> 
> Andrii Sultanov (1):
>  tools/ocaml: Specify rpath correctly for ocamlmklib
> 
> tools/ocaml/Makefile.rules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> -- 
> 2.39.5
> 

Acked-by: Christian Lindig <christian.lindig@cloud.com>