Switch flat driver to use phys dst for ext ints

[PATCH 0/3] Switch flat driver to use phys dst for ext ints

Posted by Matthew Barnes 1 month, 2 weeks ago

This patch series switches the apic_default APIC driver from using
logical flat destination mode for external interrupts, to using
physical destination mode for external interrupts.

This is followed up by two non-functional cleanup commits.

Matthew Barnes (3):
  x86/APIC: Switch flat driver to use phys dst for ext ints
  x86/APIC: Remove unnecessary logical flat functions
  x86/APIC: Refactor GENAPIC_FLAT -> GENAPIC_MIXED

 xen/arch/x86/genapic/default.c     |  2 +-
 xen/arch/x86/genapic/delivery.c    | 10 ----------
 xen/arch/x86/include/asm/genapic.h | 14 ++++++--------
 3 files changed, 7 insertions(+), 19 deletions(-)

-- 
2.46.0

Re: [PATCH 0/3] Switch flat driver to use phys dst for ext ints

Posted by Andrew Cooper 1 month, 2 weeks ago

On 02/10/2024 4:17 pm, Matthew Barnes wrote:
> This patch series switches the apic_default APIC driver from using
> logical flat destination mode for external interrupts, to using
> physical destination mode for external interrupts.
>
> This is followed up by two non-functional cleanup commits.
>
> Matthew Barnes (3):
>   x86/APIC: Switch flat driver to use phys dst for ext ints
>   x86/APIC: Remove unnecessary logical flat functions
>   x86/APIC: Refactor GENAPIC_FLAT -> GENAPIC_MIXED

Patches 1 and 2 look fine.

For patch 3, can't we just delete the macro and expand it in it's single
location?

It's a bigger patch, but a better improvement in genapic.h

~Andrew

Re: [PATCH 0/3] Switch flat driver to use phys dst for ext ints

Posted by Roger Pau Monné 1 month, 2 weeks ago

On Wed, Oct 02, 2024 at 06:45:51PM +0100, Andrew Cooper wrote:
> On 02/10/2024 4:17 pm, Matthew Barnes wrote:
> > This patch series switches the apic_default APIC driver from using
> > logical flat destination mode for external interrupts, to using
> > physical destination mode for external interrupts.
> >
> > This is followed up by two non-functional cleanup commits.
> >
> > Matthew Barnes (3):
> >   x86/APIC: Switch flat driver to use phys dst for ext ints
> >   x86/APIC: Remove unnecessary logical flat functions
> >   x86/APIC: Refactor GENAPIC_FLAT -> GENAPIC_MIXED
> 
> Patches 1 and 2 look fine.
> 
> For patch 3, can't we just delete the macro and expand it in it's single
> location?
> 
> It's a bigger patch, but a better improvement in genapic.h

I agree, but if we go that route we might as well do the conversion of
GENAPIC_PHYS in the same patch, and deal with both at the same time
(GENAPIC_PHYS is also used in a single place).

Thanks, Roger.