[PATCH v9 1/5] xen/riscv: use printk() instead of early_printk()

Oleksii Kurochko posted 5 patches 2 months, 2 weeks ago
There is a newer version of this series
[PATCH v9 1/5] xen/riscv: use printk() instead of early_printk()
Posted by Oleksii Kurochko 2 months, 2 weeks ago
As common code is available it is better to use printk() instead
of early_printk().

Also the printing of "Hello from RISC-V world" is dropped as
it is useless and "All set up is enough".

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 xen/arch/riscv/setup.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/xen/arch/riscv/setup.c b/xen/arch/riscv/setup.c
index 8bb5bdb2ae..e3cb0866d5 100644
--- a/xen/arch/riscv/setup.c
+++ b/xen/arch/riscv/setup.c
@@ -23,9 +23,7 @@ void __init noreturn start_xen(unsigned long bootcpu_id,
 {
     remove_identity_mapping();
 
-    early_printk("Hello from C env\n");
-
-    early_printk("All set up\n");
+    printk("All set up\n");
 
     for ( ;; )
         asm volatile ("wfi");
-- 
2.45.2
Re: [PATCH v9 1/5] xen/riscv: use printk() instead of early_printk()
Posted by Jan Beulich 2 months, 1 week ago
On 02.07.2024 13:23, Oleksii Kurochko wrote:
> As common code is available it is better to use printk() instead
> of early_printk().

IOW the function is not just available (allowing linking to succeed),
but is also fully functional (i.e. the line is making it out, and hence
CI, which iirc is looking for that string, is going to be "happy")? If
so:
Acked-by: Jan Beulich <jbeulich@suse.com>

Jan
Re: [PATCH v9 1/5] xen/riscv: use printk() instead of early_printk()
Posted by Oleksii 2 months, 1 week ago
On Wed, 2024-07-10 at 11:46 +0200, Jan Beulich wrote:
> On 02.07.2024 13:23, Oleksii Kurochko wrote:
> > As common code is available it is better to use printk() instead
> > of early_printk().
> 
> IOW the function is not just available (allowing linking to succeed),
> but is also fully functional (i.e. the line is making it out, and
> hence
> CI, which iirc is looking for that string, is going to be "happy")?
> If
> so:
> Acked-by: Jan Beulich <jbeulich@suse.com>

I ran our gitlab CI and it works well on my side:
https://gitlab.com/xen-project/people/olkur/xen/-/pipelines/1355999714

~ Oleksii