During Gitlab CI randconfig job for RISC-V failed witn an error:
 common/trace.c:57:22: error: expected '=', ',', ';', 'asm' or
                              '__attribute__' before '__read_mostly'
   57 | static u32 data_size __read_mostly;

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 Changes in V13:
  - new patch
---
 xen/common/trace.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/common/trace.c b/xen/common/trace.c
index c9c555094b..c33f115b6c 100644
--- a/xen/common/trace.c
+++ b/xen/common/trace.c
@@ -29,6 +29,7 @@
 #include <xen/mm.h>
 #include <xen/percpu.h>
 #include <xen/pfn.h>
+#include <xen/sections.h>
 #include <xen/cpu.h>
 #include <asm/atomic.h>
 #include <public/sysctl.h>
-- 
2.45.2

On 25.06.2024 15:51, Oleksii Kurochko wrote:
> During Gitlab CI randconfig job for RISC-V failed witn an error:
>  common/trace.c:57:22: error: expected '=', ',', ';', 'asm' or
>                               '__attribute__' before '__read_mostly'
>    57 | static u32 data_size __read_mostly;
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

If you give a release-ack, this can go in right away, I think.

Jan

On Tue, 2024-06-25 at 16:25 +0200, Jan Beulich wrote:
> On 25.06.2024 15:51, Oleksii Kurochko wrote:
> > During Gitlab CI randconfig job for RISC-V failed witn an error:
> >  common/trace.c:57:22: error: expected '=', ',', ';', 'asm' or
> >                               '__attribute__' before
> > '__read_mostly'
> >    57 | static u32 data_size __read_mostly;
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> If you give a release-ack, this can go in right away, I think.
Release-Acked-by: Oleksii Kurochko  <oleksii.kurochko@gmail.com>

~ Oleksii

On 25.06.2024 18:23, Oleksii wrote:
> On Tue, 2024-06-25 at 16:25 +0200, Jan Beulich wrote:
>> On 25.06.2024 15:51, Oleksii Kurochko wrote:
>>> During Gitlab CI randconfig job for RISC-V failed witn an error:
>>>  common/trace.c:57:22: error: expected '=', ',', ';', 'asm' or
>>>                               '__attribute__' before
>>> '__read_mostly'
>>>    57 | static u32 data_size __read_mostly;
>>>
>>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
>>
>> Acked-by: Jan Beulich <jbeulich@suse.com>
>>
>> If you give a release-ack, this can go in right away, I think.
> Release-Acked-by: Oleksii Kurochko  <oleksii.kurochko@gmail.com>

Thanks, but actually I was misled by the subject prefix. From a formal
perspective this really wants an ack from George (and mine doesn't
count anything at all).

Jan

On Wed, Jun 26, 2024 at 11:46 AM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 25.06.2024 18:23, Oleksii wrote:
> > On Tue, 2024-06-25 at 16:25 +0200, Jan Beulich wrote:
> >> On 25.06.2024 15:51, Oleksii Kurochko wrote:
> >>> During Gitlab CI randconfig job for RISC-V failed witn an error:
> >>>  common/trace.c:57:22: error: expected '=', ',', ';', 'asm' or
> >>>                               '__attribute__' before
> >>> '__read_mostly'
> >>>    57 | static u32 data_size __read_mostly;
> >>>
> >>> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> >>
> >> Acked-by: Jan Beulich <jbeulich@suse.com>
> >>
> >> If you give a release-ack, this can go in right away, I think.
> > Release-Acked-by: Oleksii Kurochko  <oleksii.kurochko@gmail.com>
>
> Thanks, but actually I was misled by the subject prefix. From a formal
> perspective this really wants an ack from George (and mine doesn't
> count anything at all).

Acked-by: George Dunlap <george.dunlap@cloud.com>