[v2] x86: address some violations of MISRA C Rule 16.3

[XEN PATCH v2 11/13] x86/pmtimer: address a violation of MISRA C Rule 16.3

Posted by Federico Serafini 5 months ago

Add missing break statement to address a violation of MISRA C Rule 16.3
("An unconditional `break' statement shall terminate every
switch-clause").

No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/arch/x86/hvm/pmtimer.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/x86/hvm/pmtimer.c b/xen/arch/x86/hvm/pmtimer.c
index 97099ac305..87a7a01c9f 100644
--- a/xen/arch/x86/hvm/pmtimer.c
+++ b/xen/arch/x86/hvm/pmtimer.c
@@ -185,6 +185,7 @@ static int cf_check handle_evt_io(
                 gdprintk(XENLOG_WARNING, 
                          "Bad ACPI PM register write: %x bytes (%x) at %x\n", 
                          bytes, *val, port);
+                break;
             }
         }
         /* Fix up the SCI state to match the new register state */
-- 
2.34.1

Re: [XEN PATCH v2 11/13] x86/pmtimer: address a violation of MISRA C Rule 16.3

Posted by Stefano Stabellini 5 months ago

On Mon, 24 Jun 2024, Federico Serafini wrote:
> Add missing break statement to address a violation of MISRA C Rule 16.3
> ("An unconditional `break' statement shall terminate every
> switch-clause").
> 
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

Re: [XEN PATCH v2 11/13] x86/pmtimer: address a violation of MISRA C Rule 16.3

Posted by Jan Beulich 5 months ago

On 24.06.2024 11:04, Federico Serafini wrote:
> Add missing break statement to address a violation of MISRA C Rule 16.3
> ("An unconditional `break' statement shall terminate every
> switch-clause").
> 
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

I'm curious though on what basis you decided to split this off of
patch 7, ...

> ---
>  xen/arch/x86/hvm/pmtimer.c | 1 +
>  1 file changed, 1 insertion(+)

... touching various other files under xen/arch/x86/hvm/.

Jan

Re: [XEN PATCH v2 11/13] x86/pmtimer: address a violation of MISRA C Rule 16.3

Posted by Federico Serafini 5 months ago

On 24/06/24 17:43, Jan Beulich wrote:
> On 24.06.2024 11:04, Federico Serafini wrote:
>> Add missing break statement to address a violation of MISRA C Rule 16.3
>> ("An unconditional `break' statement shall terminate every
>> switch-clause").
>>
>> No functional change.
>>
>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> I'm curious though on what basis you decided to split this off of
> patch 7, ...
> 
>> ---
>>   xen/arch/x86/hvm/pmtimer.c | 1 +
>>   1 file changed, 1 insertion(+)
> 
> ... touching various other files under xen/arch/x86/hvm/.

Looking at the log I found some commits where the component
name was made explicit.
I can squash it into patch 7 in a v3.

-- 
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)