[XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2

Federico Serafini posted 11 patches 2 years, 2 months ago
There is a newer version of this series
[XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2
Posted by Federico Serafini 2 years, 2 months ago
Add missing parameter names. No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/include/xen/cpumask.h | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/xen/include/xen/cpumask.h b/xen/include/xen/cpumask.h
index 9826707909..145e140481 100644
--- a/xen/include/xen/cpumask.h
+++ b/xen/include/xen/cpumask.h
@@ -460,7 +460,9 @@ extern cpumask_t cpu_present_map;
 
 /* Copy to/from cpumap provided by control tools. */
 struct xenctl_bitmap;
-int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *, const cpumask_t *);
-int xenctl_bitmap_to_cpumask(cpumask_var_t *, const struct xenctl_bitmap *);
+int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap,
+                             const cpumask_t *cpumask);
+int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask,
+                             const struct xenctl_bitmap *xenctl_cpumap);
 
 #endif /* __XEN_CPUMASK_H */
-- 
2.34.1
Re: [XEN PATCH 03/11] xen/cpumask: address violations of MISRA C:2012 Rule 8.2
Posted by Jan Beulich 2 years, 2 months ago
On 24.11.2023 15:03, Federico Serafini wrote:
> Add missing parameter names. No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Jan Beulich <jbeulich@suse.com>
irrespective of this being one of the examples where types alone are
entirely sufficient and descriptive.

Jan

> --- a/xen/include/xen/cpumask.h
> +++ b/xen/include/xen/cpumask.h
> @@ -460,7 +460,9 @@ extern cpumask_t cpu_present_map;
>  
>  /* Copy to/from cpumap provided by control tools. */
>  struct xenctl_bitmap;
> -int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *, const cpumask_t *);
> -int xenctl_bitmap_to_cpumask(cpumask_var_t *, const struct xenctl_bitmap *);
> +int cpumask_to_xenctl_bitmap(struct xenctl_bitmap *xenctl_cpumap,
> +                             const cpumask_t *cpumask);
> +int xenctl_bitmap_to_cpumask(cpumask_var_t *cpumask,
> +                             const struct xenctl_bitmap *xenctl_cpumap);
>  
>  #endif /* __XEN_CPUMASK_H */