[v2] Enable build of full Xen for RISC-V

[PATCH v2 35/39] xen: add necessary headers to common to build full Xen for RISC-V

Posted by Oleksii Kurochko 2 years ago

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
Changes in V2:
 - Nothing changed. Only rebase.
---
 xen/include/xen/domain.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index 54d88bf5e3..a4e11342e3 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -4,6 +4,7 @@
 
 #include <xen/types.h>
 
+#include <public/domctl.h>
 #include <public/xen.h>
 
 struct guest_area {
-- 
2.42.0

Re: [PATCH v2 35/39] xen: add necessary headers to common to build full Xen for RISC-V

Posted by Jan Beulich 2 years ago

On 24.11.2023 11:30, Oleksii Kurochko wrote:
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

With an empty description it is hard to judge whether this is really needed.
I would sincerely hope we can get away without. Note how there already a few
struct xen_domctl_* forward declarations there, which - if the #include
really needs adding - should be dropped in exchange.

As a nit on the subject - it's only singular (now?) and could hence do with
being more precise on what the specific change is.

Jan

> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -4,6 +4,7 @@
>  
>  #include <xen/types.h>
>  
> +#include <public/domctl.h>
>  #include <public/xen.h>
>  
>  struct guest_area {

Re: [PATCH v2 35/39] xen: add necessary headers to common to build full Xen for RISC-V

Posted by Oleksii 1 year, 12 months ago

On Thu, 2023-12-14 at 17:20 +0100, Jan Beulich wrote:
> On 24.11.2023 11:30, Oleksii Kurochko wrote:
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> 
> With an empty description it is hard to judge whether this is really
> needed.
> I would sincerely hope we can get away without. Note how there
> already a few
> struct xen_domctl_* forward declarations there, which - if the
> #include
> really needs adding - should be dropped in exchange.
> 
> As a nit on the subject - it's only singular (now?) and could hence
> do with
> being more precise on what the specific change is.
It will be another one reminder for me to write proper commit messages
as I don't remember what was an issue.

I double checked what was the issue and it seems that this change isn't
needed any more... So I'll drop this patch.

~ Oleksii
> 
> Jan
> 
> > --- a/xen/include/xen/domain.h
> > +++ b/xen/include/xen/domain.h
> > @@ -4,6 +4,7 @@
> >  
> >  #include <xen/types.h>
> >  
> > +#include <public/domctl.h>
> >  #include <public/xen.h>
> >  
> >  struct guest_area {
>