use the macro ISOLATE_LSB where appropriate

[XEN PATCH v3 0/2] use the macro ISOLATE_LSB where appropriate

Posted by Nicola Vetrini 5 months, 1 week ago

This series replaces two instances of the pattern (x & -x) with the
macro ISOLATE_LSB.

Nicola Vetrini (2):
  xen/vmap: use ISOLATE_LSB to wrap a violation of Rule 10.1
  xen/iommu: use ISOLATE_LSB to wrap a violation of Rule 10.1

 xen/common/vmap.c               | 2 +-
 xen/drivers/passthrough/iommu.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.34.1

Re: [XEN PATCH v3 0/2] use the macro ISOLATE_LSB where appropriate

Posted by Jan Beulich 5 months, 1 week ago

On 23.11.2023 08:37, Nicola Vetrini wrote:
> This series replaces two instances of the pattern (x & -x) with the
> macro ISOLATE_LSB.
> 
> Nicola Vetrini (2):
>   xen/vmap: use ISOLATE_LSB to wrap a violation of Rule 10.1
>   xen/iommu: use ISOLATE_LSB to wrap a violation of Rule 10.1
> 
>  xen/common/vmap.c               | 2 +-
>  xen/drivers/passthrough/iommu.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Just to mention it: This is an example of where tracking the various pieces
of Misra work is artificially made difficult (see e.g. earlier respective
remarks by Julien). Why wasn't this combined into a single series together
with the 3-patch one sent the same minute?

Jan

Re: [XEN PATCH v3 0/2] use the macro ISOLATE_LSB where appropriate

Posted by Nicola Vetrini 5 months, 1 week ago

On 2023-11-23 09:19, Jan Beulich wrote:
> On 23.11.2023 08:37, Nicola Vetrini wrote:
>> This series replaces two instances of the pattern (x & -x) with the
>> macro ISOLATE_LSB.
>> 
>> Nicola Vetrini (2):
>>   xen/vmap: use ISOLATE_LSB to wrap a violation of Rule 10.1
>>   xen/iommu: use ISOLATE_LSB to wrap a violation of Rule 10.1
>> 
>>  xen/common/vmap.c               | 2 +-
>>  xen/drivers/passthrough/iommu.c | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Just to mention it: This is an example of where tracking the various 
> pieces
> of Misra work is artificially made difficult (see e.g. earlier 
> respective
> remarks by Julien). Why wasn't this combined into a single series 
> together
> with the 3-patch one sent the same minute?
> 
> Jan

I didn't think of collapsing them

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)