Introduce stub headers necessary for full Xen build

[PATCH v1 22/29] xen/asm-generic: introduce stub header delay.h

Posted by Oleksii Kurochko 2 years, 3 months ago

The patch introduces header stub necessry for full Xen build.

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 xen/include/asm-generic/delay.h | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 xen/include/asm-generic/delay.h

diff --git a/xen/include/asm-generic/delay.h b/xen/include/asm-generic/delay.h
new file mode 100644
index 0000000000..1e68c6cacb
--- /dev/null
+++ b/xen/include/asm-generic/delay.h
@@ -0,0 +1,21 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef _ASM_GENERIC_DELAY_H
+#define _ASM_GENERIC_DELAY_H
+
+#include <xen/lib.h>
+
+static inline void udelay(unsigned long usecs)
+{
+    BUG();
+}
+
+#endif /* _ASM_GENERIC_DELAY_H */
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: BSD
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.41.0

Re: [PATCH v1 22/29] xen/asm-generic: introduce stub header delay.h

Posted by Oleksii 2 years, 1 month ago

Instead of introducing stub header for delay.h it was decided to remove
<asm/delay.h> in a separate patch:
https://lore.kernel.org/xen-devel/3d55bce44bd6ab9973cbe0ea2fc136cc44d35df2.1698759633.git.oleksii.kurochko@gmail.com/T/#u

~ Oleksii

Re: [PATCH v1 22/29] xen/asm-generic: introduce stub header delay.h

Posted by Jan Beulich 2 years, 2 months ago

On 14.09.2023 16:56, Oleksii Kurochko wrote:
> The patch introduces header stub necessry for full Xen build.
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
>  xen/include/asm-generic/delay.h | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 xen/include/asm-generic/delay.h

Besides the implementation below not being acceptable, imo we should do
away with asm/delay.h altogether. x86 can rename __udelay() to udelay(),
and then the declaration can move to xen/delay.h.

Jan

Re: [PATCH v1 22/29] xen/asm-generic: introduce stub header delay.h

Posted by Oleksii 2 years, 1 month ago

On Thu, 2023-10-19 at 13:30 +0200, Jan Beulich wrote:
> On 14.09.2023 16:56, Oleksii Kurochko wrote:
> > The patch introduces header stub necessry for full Xen build.
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> >  xen/include/asm-generic/delay.h | 21 +++++++++++++++++++++
> >  1 file changed, 21 insertions(+)
> >  create mode 100644 xen/include/asm-generic/delay.h
> 
> Besides the implementation below not being acceptable, imo we should
> do
> away with asm/delay.h altogether. x86 can rename __udelay() to
> udelay(),
> and then the declaration can move to xen/delay.h.
> 
It makes sense. I'll do that.

~ Oleksii