Introduce stub headers necessary for full Xen build

[PATCH v1 16/29] xen/asm-generic: introduce stub header flushtlb.h

Posted by Oleksii Kurochko 2 years, 3 months ago

The patch introduces header stub necessry for full Xen build.

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 xen/include/asm-generic/flushtlb.h | 42 ++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 xen/include/asm-generic/flushtlb.h

diff --git a/xen/include/asm-generic/flushtlb.h b/xen/include/asm-generic/flushtlb.h
new file mode 100644
index 0000000000..79e4773179
--- /dev/null
+++ b/xen/include/asm-generic/flushtlb.h
@@ -0,0 +1,42 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef __ASM_GENERIC_FLUSHTLB_H__
+#define __ASM_GENERIC_FLUSHTLB_H__
+
+#include <xen/cpumask.h>
+
+/*
+ * Filter the given set of CPUs, removing those that definitely flushed their
+ * TLB since @page_timestamp.
+ */
+/* XXX lazy implementation just doesn't clear anything.... */
+static inline void tlbflush_filter(cpumask_t *mask, uint32_t page_timestamp) {}
+
+#define tlbflush_current_time() (0)
+
+static inline void page_set_tlbflush_timestamp(struct page_info *page)
+{
+    BUG();
+}
+
+/* Flush specified CPUs' TLBs */
+void arch_flush_tlb_mask(const cpumask_t *mask);
+
+#endif /* __ASM_GENERIC_FLUSHTLB_H__ */
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
+
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: BSD
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.41.0

Re: [PATCH v1 16/29] xen/asm-generic: introduce stub header flushtlb.h

Posted by Jiamei Xie 2 years, 3 months ago

Hi Oleksii

On 2023/9/14 22:56, Oleksii Kurochko wrote:
> The patch introduces header stub necessry for full Xen build.
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
>   xen/include/asm-generic/flushtlb.h | 42 ++++++++++++++++++++++++++++++
>   1 file changed, 42 insertions(+)
>   create mode 100644 xen/include/asm-generic/flushtlb.h
>
> diff --git a/xen/include/asm-generic/flushtlb.h b/xen/include/asm-generic/flushtlb.h
> new file mode 100644
> index 0000000000..79e4773179
> --- /dev/null
> +++ b/xen/include/asm-generic/flushtlb.h
> @@ -0,0 +1,42 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __ASM_GENERIC_FLUSHTLB_H__
> +#define __ASM_GENERIC_FLUSHTLB_H__
> +
> +#include <xen/cpumask.h>
> +
> +/*
> + * Filter the given set of CPUs, removing those that definitely flushed their
> + * TLB since @page_timestamp.
> + */
> +/* XXX lazy implementation just doesn't clear anything.... */
> +static inline void tlbflush_filter(cpumask_t *mask, uint32_t page_timestamp) {}
> +
> +#define tlbflush_current_time() (0)
> +
> +static inline void page_set_tlbflush_timestamp(struct page_info *page)
> +{
> +    BUG();
> +}
> +
> +/* Flush specified CPUs' TLBs */
> +void arch_flush_tlb_mask(const cpumask_t *mask);
> +
> +#endif /* __ASM_GENERIC_FLUSHTLB_H__ */
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> +
> +
It's duplicated.
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: BSD
> + * c-basic-offset: 4
> + * indent-tabs-mode: nil
> + * End:
> + */

Re: [PATCH v1 16/29] xen/asm-generic: introduce stub header flushtlb.h

Posted by Oleksii 2 years, 3 months ago

Hello Jiamei,

On Fri, 2023-09-15 at 13:15 +0800, Jiamei Xie wrote:
> Hi Oleksii
...
> 
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: "BSD"
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */
> > +
> > +
> It's duplicated.
Thanks. I'll remove duplication.
> > +/*
> > + * Local variables:
> > + * mode: C
> > + * c-file-style: BSD
> > + * c-basic-offset: 4
> > + * indent-tabs-mode: nil
> > + * End:
> > + */

~ Oleksii