[XEN PATCH v2 0/5] python: Use setuptools instead of the deprecated distutils

Javi Merino posted 5 patches 8 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/cover.1694450145.git.javi.merino@cloud.com
README                                        |    7 -
automation/build/alpine/3.18.dockerfile       |    1 +
automation/build/archlinux/current.dockerfile |    1 +
automation/build/centos/7.dockerfile          |    3 +-
automation/build/debian/bookworm.dockerfile   |    1 +
automation/build/debian/stretch.dockerfile    |   11 +-
.../build/suse/opensuse-leap.dockerfile       |    1 +
automation/build/ubuntu/bionic.dockerfile     |    1 +
automation/build/ubuntu/focal.dockerfile      |    1 +
automation/build/ubuntu/trusty.dockerfile     |    1 +
automation/build/ubuntu/xenial.dockerfile     |    1 +
m4/python_devel.m4                            |   28 +-
tools/configure                               | 6551 +++++++++--------
tools/libs/stat/Makefile                      |    4 +-
tools/pygrub/setup.py                         |    8 +-
tools/python/setup.py                         |    8 +-
16 files changed, 3678 insertions(+), 2950 deletions(-)
[XEN PATCH v2 0/5] python: Use setuptools instead of the deprecated distutils
Posted by Javi Merino 8 months, 2 weeks ago
This series picks up Marek's v1 from
https://lore.kernel.org/xen-devel/20230316171634.320626-1-marmarek@invisiblethingslab.com/
Changes since v1:
  - Update all containers to have setuptools, as python 3.12 depecrates distutils in favour of setuptools
  - Keep python2's support by falling back to distutils if setuptools is not installed
  - Drop the commit about raising the baseline requirement for python, as we keep supporting python2

Javi Merino (2):
  automation: add python3's setuptools to containers
  README: update to remove old note about the build system's python
    expectation

Marek Marczykowski-Górecki (3):
  tools: convert setup.py to use setuptools
  tools: don't use distutils in configure nor Makefile
  tools: regenerate configure

 README                                        |    7 -
 automation/build/alpine/3.18.dockerfile       |    1 +
 automation/build/archlinux/current.dockerfile |    1 +
 automation/build/centos/7.dockerfile          |    3 +-
 automation/build/debian/bookworm.dockerfile   |    1 +
 automation/build/debian/stretch.dockerfile    |   11 +-
 .../build/suse/opensuse-leap.dockerfile       |    1 +
 automation/build/ubuntu/bionic.dockerfile     |    1 +
 automation/build/ubuntu/focal.dockerfile      |    1 +
 automation/build/ubuntu/trusty.dockerfile     |    1 +
 automation/build/ubuntu/xenial.dockerfile     |    1 +
 m4/python_devel.m4                            |   28 +-
 tools/configure                               | 6551 +++++++++--------
 tools/libs/stat/Makefile                      |    4 +-
 tools/pygrub/setup.py                         |    8 +-
 tools/python/setup.py                         |    8 +-
 16 files changed, 3678 insertions(+), 2950 deletions(-)

-- 
2.41.0


Re: [XEN PATCH v2 0/5] python: Use setuptools instead of the deprecated distutils
Posted by Andrew Cooper 8 months, 2 weeks ago
On 11/09/2023 5:50 pm, Javi Merino wrote:
> This series picks up Marek's v1 from
> https://lore.kernel.org/xen-devel/20230316171634.320626-1-marmarek@invisiblethingslab.com/
> Changes since v1:
>   - Update all containers to have setuptools, as python 3.12 depecrates distutils in favour of setuptools
>   - Keep python2's support by falling back to distutils if setuptools is not installed
>   - Drop the commit about raising the baseline requirement for python, as we keep supporting python2
>
> Javi Merino (2):
>   automation: add python3's setuptools to containers
>   README: update to remove old note about the build system's python
>     expectation
>
> Marek Marczykowski-Górecki (3):
>   tools: convert setup.py to use setuptools
>   tools: don't use distutils in configure nor Makefile
>   tools: regenerate configure

Two general notes.

First, because you've (re)arranged and posted this series, you need to
add your own Signed-off-by line to all patches, even unmodified ones
Marek's that you've included.  SoB needs to be from everyone involved in
handling the patch.

Second, patch 4 should be dropped, and a note put in patch 2 to the
committer, who will use autoconf 2.69 and have a far far smaller delta
to include.

~Andrew

Re: [XEN PATCH v2 0/5] python: Use setuptools instead of the deprecated distutils
Posted by Javi Merino 8 months, 1 week ago
On Tue, Sep 12, 2023 at 08:49:04AM +0100, Andrew Cooper wrote:
> On 11/09/2023 5:50 pm, Javi Merino wrote:
> > This series picks up Marek's v1 from
> > https://lore.kernel.org/xen-devel/20230316171634.320626-1-marmarek@invisiblethingslab.com/
> > Changes since v1:
> >   - Update all containers to have setuptools, as python 3.12 depecrates distutils in favour of setuptools
> >   - Keep python2's support by falling back to distutils if setuptools is not installed
> >   - Drop the commit about raising the baseline requirement for python, as we keep supporting python2
> >
> > Javi Merino (2):
> >   automation: add python3's setuptools to containers
> >   README: update to remove old note about the build system's python
> >     expectation
> >
> > Marek Marczykowski-Górecki (3):
> >   tools: convert setup.py to use setuptools
> >   tools: don't use distutils in configure nor Makefile
> >   tools: regenerate configure
> 
> Two general notes.
> 
> First, because you've (re)arranged and posted this series, you need to
> add your own Signed-off-by line to all patches, even unmodified ones
> Marek's that you've included.  SoB needs to be from everyone involved in
> handling the patch.

Sure.

> Second, patch 4 should be dropped, and a note put in patch 2 to the
> committer, who will use autoconf 2.69 and have a far far smaller delta
> to include.

I have regenerated it with 2.69 and the diff for tools/configure is
reduced to:

 tools/configure | 52 ++++++++++++++++++++--------------------------------
 1 file changed, 20 insertions(+), 32 deletions(-)

Cheers,
Javi