[XEN PATCH 0/6] xen: fix missing headers and static storage duration

Nicola Vetrini posted 6 patches 1 year, 3 months ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/cover.1691676251.git.nicola.vetrini@bugseng.com
xen/arch/x86/hpet.c              |  2 +-
xen/arch/x86/include/asm/setup.h |  6 ------
xen/arch/x86/setup.c             |  4 +++-
xen/arch/x86/vm_event.c          |  1 +
xen/drivers/cpufreq/cpufreq.c    |  1 +
xen/drivers/video/vga.c          |  9 +--------
xen/drivers/vpci/msix.c          |  2 +-
xen/include/xen/cpuidle.h        |  2 +-
xen/include/xen/vga.h            | 14 ++++++++++++++
9 files changed, 23 insertions(+), 18 deletions(-)
[XEN PATCH 0/6] xen: fix missing headers and static storage duration
Posted by Nicola Vetrini 1 year, 3 months ago
The files touched by this series contain function or variable definitions with
no prior declaration visible, because it's inside an header that is not included
or it's not present anywhere. This is a risk in itself, but also violates
MISRA C:2012 Rule 8.4, which states the following:
"A compatible declaration shall be visible when an object or function with
external linkage is defined".

The resolution strategies are as follows:

1. make the functions/variables static
2. include the header that contains the compatible declaration, or add one in
   the header if that's not the case.

No functional change.

Additional notes:
- This series is a continuation of the work done here [1], so the same additional
  notes apply.

[1] https://lore.kernel.org/xen-devel/cover.1691655814.git.nicola.vetrini@bugseng.com/T/#m28da1b5ef8d9a7683937bfc345765e3438b89977

Nicola Vetrini (6):
  x86/hpet: make variable 'per_cpu__cpu_bc_channel' static
  x86/setup: add missing headers
  x86/vm_event: add missing include
  cpufreq: add missing include of header 'pmstat.h'
  vpic/msix: make 'get_slot' static
  drivers/video: make declarations of defined functions available

 xen/arch/x86/hpet.c              |  2 +-
 xen/arch/x86/include/asm/setup.h |  6 ------
 xen/arch/x86/setup.c             |  4 +++-
 xen/arch/x86/vm_event.c          |  1 +
 xen/drivers/cpufreq/cpufreq.c    |  1 +
 xen/drivers/video/vga.c          |  9 +--------
 xen/drivers/vpci/msix.c          |  2 +-
 xen/include/xen/cpuidle.h        |  2 +-
 xen/include/xen/vga.h            | 14 ++++++++++++++
 9 files changed, 23 insertions(+), 18 deletions(-)

--
2.34.1