[v2] RISCV basic exception handling implementation

[PATCH v2 14/14] automation: add smoke test to verify macros from bug.h

Posted by Oleksii Kurochko 3 years ago

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
Changes in V2:
 - Leave only the latest "grep ..."
---
 automation/scripts/qemu-smoke-riscv64.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh
index e0f06360bc..02fc66be03 100755
--- a/automation/scripts/qemu-smoke-riscv64.sh
+++ b/automation/scripts/qemu-smoke-riscv64.sh
@@ -16,5 +16,5 @@ qemu-system-riscv64 \
     |& tee smoke.serial
 
 set -e
-(grep -q "Hello from C env" smoke.serial) || exit 1
+(grep -q "WARN is most likely working" smoke.serial) || exit 1
 exit 0
-- 
2.39.0

Re: [PATCH v2 14/14] automation: add smoke test to verify macros from bug.h

Posted by Michal Orzel 3 years ago

Hi Oleksii,

On 27/01/2023 14:59, Oleksii Kurochko wrote:
> 
> 
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> ---
> Changes in V2:
>  - Leave only the latest "grep ..."
> ---
>  automation/scripts/qemu-smoke-riscv64.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/automation/scripts/qemu-smoke-riscv64.sh b/automation/scripts/qemu-smoke-riscv64.sh
> index e0f06360bc..02fc66be03 100755
> --- a/automation/scripts/qemu-smoke-riscv64.sh
> +++ b/automation/scripts/qemu-smoke-riscv64.sh
> @@ -16,5 +16,5 @@ qemu-system-riscv64 \
>      |& tee smoke.serial
> 
>  set -e
> -(grep -q "Hello from C env" smoke.serial) || exit 1
> +(grep -q "WARN is most likely working" smoke.serial) || exit 1
I think the commit msg is a bit misleading and should be changed.
FWICS, you are not *adding* any smoke test but instead modifying
the grep pattern to reflect the usage of WARN.

>  exit 0
> --
> 2.39.0
> 
> 

~Michal

Re: [PATCH v2 14/14] automation: add smoke test to verify macros from bug.h

Posted by Oleksii 3 years ago

On Fri, 2023-01-27 at 15:43 +0100, Michal Orzel wrote:
> Hi Oleksii,
> 
> On 27/01/2023 14:59, Oleksii Kurochko wrote:
> > 
> > 
> > Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
> > ---
> > Changes in V2:
> >  - Leave only the latest "grep ..."
> > ---
> >  automation/scripts/qemu-smoke-riscv64.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/automation/scripts/qemu-smoke-riscv64.sh
> > b/automation/scripts/qemu-smoke-riscv64.sh
> > index e0f06360bc..02fc66be03 100755
> > --- a/automation/scripts/qemu-smoke-riscv64.sh
> > +++ b/automation/scripts/qemu-smoke-riscv64.sh
> > @@ -16,5 +16,5 @@ qemu-system-riscv64 \
> >      |& tee smoke.serial
> > 
> >  set -e
> > -(grep -q "Hello from C env" smoke.serial) || exit 1
> > +(grep -q "WARN is most likely working" smoke.serial) || exit 1
> I think the commit msg is a bit misleading and should be changed.
> FWICS, you are not *adding* any smoke test but instead modifying
> the grep pattern to reflect the usage of WARN.
> 
It's incorrect so it will be changed in the new version of the patch
series.

Thanks.
> >  exit 0
> > --
> > 2.39.0
> > 
> > 
> 
> ~Michal