Pyhton3 package is requited by automation/scripts/build
script so it shoud be installed to riscv64 docker image

Signed-off-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
---
 automation/build/archlinux/riscv64.dockerfile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/automation/build/archlinux/riscv64.dockerfile b/automation/build/archlinux/riscv64.dockerfile
index ff8b2b955d..a52852c2f7 100644
--- a/automation/build/archlinux/riscv64.dockerfile
+++ b/automation/build/archlinux/riscv64.dockerfile
@@ -9,7 +9,8 @@ RUN pacman --noconfirm --needed -Syu \
     inetutils \
     riscv64-linux-gnu-binutils \
     riscv64-linux-gnu-gcc \
-    riscv64-linux-gnu-glibc
+    riscv64-linux-gnu-glibc \
+    python3
 
 # Add compiler path
 ENV CROSS_COMPILE=riscv64-linux-gnu-
-- 
2.38.1

On 23/12/2022 11:16 am, Oleksii Kurochko wrote:
> Pyhton3 package is requited by automation/scripts/build
> script so it shoud be installed to riscv64 docker image

Is it?  This series runs fine without it.

When we get around to compiling userspace, then we do need a python
interpreter for the build, but we need a load of other things too.

~Andrew

On Wed, 2022-12-28 at 23:26 +0000, Andrew Cooper wrote:
> On 23/12/2022 11:16 am, Oleksii Kurochko wrote:
> > Pyhton3 package is requited by automation/scripts/build
> > script so it shoud be installed to riscv64 docker image
> 
> Is it?  This series runs fine without it.
> 

It is used by automation/scripts/build here:
https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/automation/scripts/build#L63

It looks like this patch can be skipped for now as it doesn't affect
results of RISC-V cross-build test.

> When we get around to compiling userspace, then we do need a python
> interpreter for the build, but we need a load of other things too.
> 
> ~Andrew

~Oleksii

On 29/12/2022 7:45 am, Oleksii wrote:
> On Wed, 2022-12-28 at 23:26 +0000, Andrew Cooper wrote:
>> On 23/12/2022 11:16 am, Oleksii Kurochko wrote:
>>> Pyhton3 package is requited by automation/scripts/build
>>> script so it shoud be installed to riscv64 docker image
>> Is it?  This series runs fine without it.
>>
> It is used by automation/scripts/build here:
> https://gitlab.com/xen-project/people/olkur/xen/-/blob/staging/automation/scripts/build#L63

That logic reads "if ( !py3 || !(py3.ver > 3.5) ) skip" so is fine with
no py3.  Some of the older build containers only have py2.

>
> It looks like this patch can be skipped for now as it doesn't affect
> results of RISC-V cross-build test.

Yeah, it can be dropped for now.

~Andrew