Some bits I had run across when looking at a piece of libxl.
Even though the purpose of the functions suggests they won't modify the
memory passed in via pointer, marking them constant provides better
reassurance.
While list_domains_details() and printf_info() had similar purposes their
interfaces were wildly different. Make them more consistent. I was
aiming to turn dump_by_dominfo_list() into a wrapper around
dump_by_config(), but didn't quite get there.
Having the functions named "printf" is wrong. They are generating output
in a fixed format, there is no control over the format. That is a write
or dump operation, not a formatted print.
Elliott Mitchell (5):
tools/libxl: Mark pointer args of many functions constant
tools/xl: Mark libxl_domain_config * arg of printf_info_*() const
tools/xl: Rename printf_info()/list_domains_details() to dump_by_...()
tools/xl: Merge down debug/dry-run section of create_domain()
tools/xl: Fix potential deallocation bug
tools/include/libxl_json.h | 22 +++++++++++---------
tools/libs/light/gentypes.py | 8 ++++----
tools/libs/light/libxl_cpuid.c | 2 +-
tools/libs/light/libxl_internal.c | 4 ++--
tools/libs/light/libxl_internal.h | 18 ++++++++--------
tools/libs/light/libxl_json.c | 18 ++++++++--------
tools/libs/light/libxl_nocpuid.c | 4 ++--
tools/xl/xl.h | 10 ++++++++-
tools/xl/xl_info.c | 34 ++++++++++++++++---------------
tools/xl/xl_misc.c | 5 +----
tools/xl/xl_sxp.c | 6 +++---
tools/xl/xl_vmcontrol.c | 14 +------------
12 files changed, 72 insertions(+), 73 deletions(-)
--
2.30.2