Fix fall-through warnings for Clang

[PATCH 138/141] xen/manage: Fix fall-through warnings for Clang

Posted by Gustavo A. R. Silva 5 years, 2 months ago

In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
 drivers/xen/manage.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index cd046684e0d1..374d36de7f5a 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -179,6 +179,7 @@ static int poweroff_nb(struct notifier_block *cb, unsigned long code, void *unus
 	case SYS_HALT:
 	case SYS_POWER_OFF:
 		shutting_down = SHUTDOWN_POWEROFF;
+		break;
 	default:
 		break;
 	}
-- 
2.27.0

Re: [PATCH 138/141] xen/manage: Fix fall-through warnings for Clang

Posted by Jürgen Groß 5 years, 1 month ago

On 20.11.20 19:40, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>

Applied to: xen/tip.git for-linus-5.11


Juergen

[PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang
[PATCH 138/141] xen/manage: Fix fall-through warnings for Clang