ACPI: adjust decl of acpi_set_pdc_bits()

[PATCH] ACPI: adjust decl of acpi_set_pdc_bits()

Posted by Jan Beulich 4 months, 3 weeks ago

The commit referenced below changed the type of the first parameter.
Misra C:2012 Rule 8.3 requires the declaration to follow suit.

Fixes: bf0cd071db2a ("xen/pmstat: consolidate code into pmstat.c")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/acpi.h
+++ b/xen/include/xen/acpi.h
@@ -186,7 +186,7 @@ static inline void acpi_set_csubstate_li
 #endif
 
 #ifdef XEN_GUEST_HANDLE
-int acpi_set_pdc_bits(uint32_t acpi_id, XEN_GUEST_HANDLE(uint32));
+int acpi_set_pdc_bits(unsigned int acpi_id, XEN_GUEST_HANDLE(uint32));
 #endif
 int arch_acpi_set_pdc_bits(u32 acpi_id, u32 *, u32 mask);

Re: [PATCH] ACPI: adjust decl of acpi_set_pdc_bits()

Posted by Nicola Vetrini 4 months, 3 weeks ago

On 2025-06-11 13:53, Jan Beulich wrote:
> The commit referenced below changed the type of the first parameter.
> Misra C:2012 Rule 8.3 requires the declaration to follow suit.
> 
> Fixes: bf0cd071db2a ("xen/pmstat: consolidate code into pmstat.c")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 

Reviewed-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

> --- a/xen/include/xen/acpi.h
> +++ b/xen/include/xen/acpi.h
> @@ -186,7 +186,7 @@ static inline void acpi_set_csubstate_li
>  #endif
> 
>  #ifdef XEN_GUEST_HANDLE
> -int acpi_set_pdc_bits(uint32_t acpi_id, XEN_GUEST_HANDLE(uint32));
> +int acpi_set_pdc_bits(unsigned int acpi_id, XEN_GUEST_HANDLE(uint32));
>  #endif
>  int arch_acpi_set_pdc_bits(u32 acpi_id, u32 *, u32 mask);

-- 
Nicola Vetrini, B.Sc.
Software Engineer
BUGSENG (https://bugseng.com)
LinkedIn: https://www.linkedin.com/in/nicola-vetrini-a42471253