x86emul/test: correct VSCALEF{P,S}{S,D} entries in predicates test

[PATCH] x86emul/test: correct VSCALEF{P,S}{S,D} entries in predicates test

Posted by Jan Beulich 2 years, 8 months ago

I can't see why these would want / need to suppress testing of the
register forms of the insns. Quite likely a copy-and-paste oversight
when originally creating the table.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/x86_emulator/predicates.c
+++ b/tools/tests/x86_emulator/predicates.c
@@ -1822,8 +1822,8 @@ static const struct evex {
     { { 0x2a }, 2, F, R, pfx_66, W0, Ln }, /* vmovntdqa */
     { { 0x2a, 0xc0 }, 2, F, N, pfx_f3, W1, Ln }, /* vpbroadcastmb2q */
     { { 0x2b }, 2, T, R, pfx_66, W0, Ln }, /* vpackusdw */
-    { { 0x2c }, 2, F, R, pfx_66, Wn, Ln }, /* vscalefp{s,d} */
-    { { 0x2d }, 2, F, R, pfx_66, Wn, LIG }, /* vscalefs{s,d} */
+    { { 0x2c }, 2, T, R, pfx_66, Wn, Ln }, /* vscalefp{s,d} */
+    { { 0x2d }, 2, T, R, pfx_66, Wn, LIG }, /* vscalefs{s,d} */
     { { 0x30 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbw */
     { { 0x30 }, 2, T, W, pfx_f3, W0, Ln }, /* vpmovwb */
     { { 0x31 }, 2, T, R, pfx_66, WIG, Ln }, /* vpmovzxbd */

Re: [PATCH] x86emul/test: correct VSCALEF{P,S}{S,D} entries in predicates test

Posted by Andrew Cooper 2 years, 8 months ago

On 16/03/2022 10:43, Jan Beulich wrote:
> I can't see why these would want / need to suppress testing of the
> register forms of the insns. Quite likely a copy-and-paste oversight
> when originally creating the table.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>