[PATCH] xen/manage: Constify struct shutdown_handler

Christophe JAILLET posted 1 patch 5 months ago
Failed in applying to current master (apply log)
There is a newer version of this series
drivers/xen/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] xen/manage: Constify struct shutdown_handler
Posted by Christophe JAILLET 5 months ago
'struct shutdown_handler' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increase overall security.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
   7043	    788	      8	   7839	   1e9f	drivers/xen/manage.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
   7164	    676	      8	   7848	   1ea8	drivers/xen/manage.o

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested-only
---
 drivers/xen/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index c16df629907e..b4b4ebed68da 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -208,7 +208,7 @@ static void do_reboot(void)
 	orderly_reboot();
 }
 
-static struct shutdown_handler shutdown_handlers[] = {
+static const struct shutdown_handler shutdown_handlers[] = {
 	{ "poweroff",	true,	do_poweroff },
 	{ "halt",	false,	do_poweroff },
 	{ "reboot",	true,	do_reboot   },
-- 
2.45.2
Re: [PATCH] xen/manage: Constify struct shutdown_handler
Posted by Jürgen Groß 5 months ago
On 23.06.24 11:26, Christophe JAILLET wrote:
> 'struct shutdown_handler' is not modified in this driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
>     text	   data	    bss	    dec	    hex	filename
>     7043	    788	      8	   7839	   1e9f	drivers/xen/manage.o
> 
> After:
> =====
>     text	   data	    bss	    dec	    hex	filename
>     7164	    676	      8	   7848	   1ea8	drivers/xen/manage.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen