libxl: except Dom0 from setting PoD target

[PATCH] libxl: except Dom0 from setting PoD target

Posted by Jan Beulich 2 months ago

Dom0 is never started in PoD mode, and hence it can at "best" do harm if
we try to set a PoD target for it.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/libs/light/libxl_mem.c
+++ b/tools/libs/light/libxl_mem.c
@@ -306,7 +306,7 @@ retry_transaction:
         }
     }
 
-    if (d_config.c_info.type != LIBXL_DOMAIN_TYPE_PV) {
+    if (domid && d_config.c_info.type != LIBXL_DOMAIN_TYPE_PV) {
         r = xc_domain_set_pod_target(ctx->xch, domid,
                 (new_target_memkb + size) / 4, NULL, NULL, NULL);
         if (r != 0) {

Re: [PATCH] libxl: except Dom0 from setting PoD target

Posted by Jason Andryuk 2 months ago

On 2025-08-27 01:53, Jan Beulich wrote:
> Dom0 is never started in PoD mode, and hence it can at "best" do harm if
> we try to set a PoD target for it.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>

Did you observe an issue, or just notice this when inspecting the code? 
If an issue, please add to the commit message.

Thanks,
Jason

Re: [PATCH] libxl: except Dom0 from setting PoD target

Posted by Anthony PERARD 1 month, 3 weeks ago

On Wed, Aug 27, 2025 at 09:08:10PM -0400, Jason Andryuk wrote:
> On 2025-08-27 01:53, Jan Beulich wrote:
> > Dom0 is never started in PoD mode, and hence it can at "best" do harm if
> > we try to set a PoD target for it.
> > 
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>

Acked-by: Anthony PERARD <anthony.perard@vates.tech>

Thanks,

-- 
Anthony PERARD

Re: [PATCH] libxl: except Dom0 from setting PoD target

Posted by Jan Beulich 2 months ago

On 28.08.2025 03:08, Jason Andryuk wrote:
> On 2025-08-27 01:53, Jan Beulich wrote:
>> Dom0 is never started in PoD mode, and hence it can at "best" do harm if
>> we try to set a PoD target for it.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>

Thanks.

> Did you observe an issue, or just notice this when inspecting the code? 

It simply caught my eye while investigating the ballooning issue I sent
a mail about.

> If an issue, please add to the commit message.

I would have, sure.

Jan