VT-d: drop undue address-of from check_cleanup_domid_map()

[PATCH 4.16] VT-d: drop undue address-of from check_cleanup_domid_map()

Posted by Jan Beulich 2 years, 1 month ago

For an unknown reason I added back the operator while backporting,
despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs
to have dynamic size"). I can only assume that I mistakenly took the
4.15 backport as basis and/or reference.

Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/drivers/passthrough/vtd/iommu.c
+++ b/xen/drivers/passthrough/vtd/iommu.c
@@ -197,7 +197,7 @@ static void check_cleanup_domid_map(stru
 
     if ( !found )
     {
-        clear_bit(iommu->index, &dom_iommu(d)->arch.vtd.iommu_bitmap);
+        clear_bit(iommu->index, dom_iommu(d)->arch.vtd.iommu_bitmap);
         cleanup_domid_map(d, iommu);
     }
 }

RE: [PATCH 4.16] VT-d: drop undue address-of from check_cleanup_domid_map()

Posted by Tian, Kevin 2 years, 1 month ago

> From: Jan Beulich <jbeulich@suse.com>
> Sent: Tuesday, March 8, 2022 11:27 PM
> 
> For an unknown reason I added back the operator while backporting,
> despite 4.16 having c06e3d810314 ("VT-d: per-domain IOMMU bitmap needs
> to have dynamic size"). I can only assume that I mistakenly took the
> 4.15 backport as basis and/or reference.
> 
> Fixes: fa45f6b5560e ("VT-d: split domid map cleanup check into a function")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>

> 
> --- a/xen/drivers/passthrough/vtd/iommu.c
> +++ b/xen/drivers/passthrough/vtd/iommu.c
> @@ -197,7 +197,7 @@ static void check_cleanup_domid_map(stru
> 
>      if ( !found )
>      {
> -        clear_bit(iommu->index, &dom_iommu(d)->arch.vtd.iommu_bitmap);
> +        clear_bit(iommu->index, dom_iommu(d)->arch.vtd.iommu_bitmap);
>          cleanup_domid_map(d, iommu);
>      }
>  }