[PATCH v3 0/7] (mainly) xz imports from Linux

Jan Beulich posted 7 patches 2 years, 1 month ago
Failed in applying to current master (apply log)
[PATCH v3 0/7] (mainly) xz imports from Linux
Posted by Jan Beulich 2 years, 1 month ago
While going through their 5.15.3 log I did notice two changes, which made
me go check what else we might be missing. The series here is the result.
Linux has also updated zstd, but that includes a pretty large change which
I'm not ready to deal with right now. Them moving closer to the upstream
zstd sources is certainly a good thing, so I suppose sooner or later we
will want to follow them in doing so.

The only change in v3 is the re-adding of some previously dropped S-o-b in
patches 2 and 3, to satisfy the rules newly established by 5e326b61693c.

As the series has R-b by Luca and as the (not) retaining of certain tags
was the only open issue in v1 and v2, I won't wait long until committing
this; perhaps just until after the weekend.

1: xz: add fall-through comments to a switch statement
2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
3: decompressors: fix spelling mistakes
4: xz: avoid overlapping memcpy() with invalid input with in-place decompression
5: xz: fix spelling in comments
6: xz: move s->lzma.len = 0 initialization to lzma_reset()
7: xz: validate the value before assigning it to an enum variable

Jan
Re: [PATCH v3 0/7] (mainly) xz imports from Linux
Posted by Jan Beulich 2 years, 1 month ago
On 03.03.2022 11:03, Jan Beulich wrote:
> While going through their 5.15.3 log I did notice two changes, which made
> me go check what else we might be missing. The series here is the result.
> Linux has also updated zstd, but that includes a pretty large change which
> I'm not ready to deal with right now. Them moving closer to the upstream
> zstd sources is certainly a good thing, so I suppose sooner or later we
> will want to follow them in doing so.
> 
> The only change in v3 is the re-adding of some previously dropped S-o-b in
> patches 2 and 3, to satisfy the rules newly established by 5e326b61693c.
> 
> As the series has R-b by Luca and as the (not) retaining of certain tags
> was the only open issue in v1 and v2, I won't wait long until committing
> this; perhaps just until after the weekend.

I did notice only when already in the process of sending that I should also
have converted to the new Origin: tag. I've done this locally, but won't
resend just for this.

Jan

> 1: xz: add fall-through comments to a switch statement
> 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
> 3: decompressors: fix spelling mistakes
> 4: xz: avoid overlapping memcpy() with invalid input with in-place decompression
> 5: xz: fix spelling in comments
> 6: xz: move s->lzma.len = 0 initialization to lzma_reset()
> 7: xz: validate the value before assigning it to an enum variable
> 
> Jan
Re: [PATCH v3 0/7] (mainly) xz imports from Linux
Posted by Andrew Cooper 2 years, 1 month ago
On 03/03/2022 10:03, Jan Beulich wrote:
> 1: xz: add fall-through comments to a switch statement
> 2: xz: fix XZ_DYNALLOC to avoid useless memory reallocations
> 3: decompressors: fix spelling mistakes
> 4: xz: avoid overlapping memcpy() with invalid input with in-place decompression
> 5: xz: fix spelling in comments
> 6: xz: move s->lzma.len = 0 initialization to lzma_reset()
> 7: xz: validate the value before assigning it to an enum variable

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>