xen/vPCI: address violation of MISRA C:2012 Rule 8.3

[XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3

Posted by Federico Serafini 7 months, 3 weeks ago

Make function declaration consistent with the corresponding definition.
No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/include/xen/vpci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
index 0b8a2a3c74..d743d96a10 100644
--- a/xen/include/xen/vpci.h
+++ b/xen/include/xen/vpci.h
@@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
                __used_section(".data.vpci." p) = x
 
 /* Add vPCI handlers to device. */
-int __must_check vpci_add_handlers(struct pci_dev *dev);
+int __must_check vpci_add_handlers(struct pci_dev *pdev);
 
 /* Remove all handlers and free vpci related structures. */
 void vpci_remove_device(struct pci_dev *pdev);
-- 
2.34.1

Re: [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3

Posted by Roger Pau Monné 7 months, 1 week ago

On Fri, Sep 08, 2023 at 11:13:31AM +0200, Federico Serafini wrote:
> Make function declaration consistent with the corresponding definition.
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.

Re: [XEN PATCH] xen/vPCI: address violation of MISRA C:2012 Rule 8.3

Posted by Federico Serafini 7 months, 1 week ago

On 08/09/23 11:13, Federico Serafini wrote:
> Make function declaration consistent with the corresponding definition.
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> ---
>   xen/include/xen/vpci.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h
> index 0b8a2a3c74..d743d96a10 100644
> --- a/xen/include/xen/vpci.h
> +++ b/xen/include/xen/vpci.h
> @@ -26,7 +26,7 @@ typedef int vpci_register_init_t(struct pci_dev *dev);
>                  __used_section(".data.vpci." p) = x
>   
>   /* Add vPCI handlers to device. */
> -int __must_check vpci_add_handlers(struct pci_dev *dev);
> +int __must_check vpci_add_handlers(struct pci_dev *pdev);
>   
>   /* Remove all handlers and free vpci related structures. */
>   void vpci_remove_device(struct pci_dev *pdev);

Are there any chances of getting an ack?

-- 
Federico Serafini, M.Sc.

Software Engineer, BUGSENG (http://bugseng.com)