include/ctype.h: fix MISRA R10.2 violation

[PATCH v2] include/ctype.h: fix MISRA R10.2 violation

Posted by Stefano Stabellini 6 months, 1 week ago

The value returned by __toupper is used in arithmetic operations causing
MISRA C 10.2 violations. Cast to plain char in the toupper macro. Also
do the same in tolower for consistency.

Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>
---
Changes in v2:
- fix the toupper macro instead

diff --git a/xen/include/xen/ctype.h b/xen/include/xen/ctype.h
index 6dec944a37..773ac27aa4 100644
--- a/xen/include/xen/ctype.h
+++ b/xen/include/xen/ctype.h
@@ -48,7 +48,7 @@ static inline unsigned char __toupper(unsigned char c)
 	return c;
 }
 
-#define tolower(c) __tolower(c)
-#define toupper(c) __toupper(c)
+#define tolower(c) ((char)__tolower(c))
+#define toupper(c) ((char)__toupper(c))
 
 #endif

Re: [PATCH v2] include/ctype.h: fix MISRA R10.2 violation

Posted by Jan Beulich 6 months, 1 week ago

On 16.05.2024 00:52, Stefano Stabellini wrote:
> The value returned by __toupper is used in arithmetic operations causing
> MISRA C 10.2 violations. Cast to plain char in the toupper macro. Also
> do the same in tolower for consistency.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com>

Acked-by: Jan Beulich <jbeulich@suse.com>