Config.mk: update MiniOS commit

[PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Jan Beulich 1 year, 7 months ago

Pull in the gcc14 build fix there.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Probably nice to reference a gcc14-clean MiniOS tree from what is going
to be 4.19.

--- a/Config.mk
+++ b/Config.mk
@@ -224,7 +224,7 @@ QEMU_UPSTREAM_URL ?= https://xenbits.xen
 QEMU_UPSTREAM_REVISION ?= master
 
 MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git
-MINIOS_UPSTREAM_REVISION ?= b6a5b4d72b88e5c4faed01f5a44505de022860fc
+MINIOS_UPSTREAM_REVISION ?= 8b038c7411ae7e823eaf6d15d5efbe037a07197a
 
 SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git
 SEABIOS_UPSTREAM_REVISION ?= rel-1.16.3

Re: [PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Oleksii 1 year, 7 months ago

On Tue, 2024-06-25 at 09:57 +0200, Jan Beulich wrote:
> Pull in the gcc14 build fix there.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>

~ Oleksii

> ---
> Probably nice to reference a gcc14-clean MiniOS tree from what is
> going
> to be 4.19.
> 
> --- a/Config.mk
> +++ b/Config.mk
> @@ -224,7 +224,7 @@ QEMU_UPSTREAM_URL ?= https://xenbits.xen
>  QEMU_UPSTREAM_REVISION ?= master
>  
>  MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git
> -MINIOS_UPSTREAM_REVISION ?= b6a5b4d72b88e5c4faed01f5a44505de022860fc
> +MINIOS_UPSTREAM_REVISION ?= 8b038c7411ae7e823eaf6d15d5efbe037a07197a
>  
>  SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git
>  SEABIOS_UPSTREAM_REVISION ?= rel-1.16.3

Re: [PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Oleksii 1 year, 7 months ago

On Tue, 2024-06-25 at 09:57 +0200, Jan Beulich wrote:
> Pull in the gcc14 build fix there.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> Probably nice to reference a gcc14-clean MiniOS tree from what is
> going
> to be 4.19.
I would like to ask what do you mean by gcc14-clean here?

~ Oleksii

> 
> --- a/Config.mk
> +++ b/Config.mk
> @@ -224,7 +224,7 @@ QEMU_UPSTREAM_URL ?= https://xenbits.xen
>  QEMU_UPSTREAM_REVISION ?= master
>  
>  MINIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/mini-os.git
> -MINIOS_UPSTREAM_REVISION ?= b6a5b4d72b88e5c4faed01f5a44505de022860fc
> +MINIOS_UPSTREAM_REVISION ?= 8b038c7411ae7e823eaf6d15d5efbe037a07197a
>  
>  SEABIOS_UPSTREAM_URL ?= https://xenbits.xen.org/git-http/seabios.git
>  SEABIOS_UPSTREAM_REVISION ?= rel-1.16.3

Re: [PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Jan Beulich 1 year, 7 months ago

On 25.06.2024 10:10, Oleksii wrote:
> On Tue, 2024-06-25 at 09:57 +0200, Jan Beulich wrote:
>> Pull in the gcc14 build fix there.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> ---
>> Probably nice to reference a gcc14-clean MiniOS tree from what is
>> going
>> to be 4.19.
> I would like to ask what do you mean by gcc14-clean here?

Being able to build successfully with (recently released) gcc14, out of
the box.

Jan

Re: [PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Oleksii 1 year, 7 months ago

On Tue, 2024-06-25 at 10:26 +0200, Jan Beulich wrote:
> On 25.06.2024 10:10, Oleksii wrote:
> > On Tue, 2024-06-25 at 09:57 +0200, Jan Beulich wrote:
> > > Pull in the gcc14 build fix there.
> > > 
> > > Signed-off-by: Jan Beulich <jbeulich@suse.com>
> > > ---
> > > Probably nice to reference a gcc14-clean MiniOS tree from what is
> > > going
> > > to be 4.19.
> > I would like to ask what do you mean by gcc14-clean here?
> 
> Being able to build successfully with (recently released) gcc14, out
> of
> the box.
Sorry for not asking that in initial reply.

I am still confused with "from what is going to be 4.19".

Are this words about gcc version used by Xen itself?
If yes, then before this patch gcc version of Xen and MiniOS was the
same?

~ Oleksii

Re: [PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Andrew Cooper 1 year, 7 months ago

On 25/06/2024 3:02 pm, Oleksii wrote:
> On Tue, 2024-06-25 at 10:26 +0200, Jan Beulich wrote:
>> On 25.06.2024 10:10, Oleksii wrote:
>>> On Tue, 2024-06-25 at 09:57 +0200, Jan Beulich wrote:
>>>> Pull in the gcc14 build fix there.
>>>>
>>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>> ---
>>>> Probably nice to reference a gcc14-clean MiniOS tree from what is
>>>> going
>>>> to be 4.19.
>>> I would like to ask what do you mean by gcc14-clean here?
>> Being able to build successfully with (recently released) gcc14, out
>> of
>> the box.
> Sorry for not asking that in initial reply.
>
> I am still confused with "from what is going to be 4.19".
>
> Are this words about gcc version used by Xen itself?
> If yes, then before this patch gcc version of Xen and MiniOS was the
> same?

A release of Xen is more than just xen.git.

In this case, https://xenbits.xen.org/gitweb/?p=mini-os.git;a=summary
took a bugfix for GCC-14, and xen.git's reference to it needs updating.

MiniOS is one of the components used by xen.git/stubdom/*

~Andrew

Re: [PATCH for-4.19?] Config.mk: update MiniOS commit

Posted by Jürgen Groß 1 year, 7 months ago

On 25.06.24 09:57, Jan Beulich wrote:
> Pull in the gcc14 build fix there.
> 
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen