xen: fix comment typo in xen.h

[PATCH] xen: fix comment typo in xen.h

Posted by Ruslan Vagner 1 week, 2 days ago

Fix the spelling in comments. No functional change.

Signed-off-by: Ruslan Vagner <rusya92266@gmail.com>
---
 include/xen/interface/xen.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/xen/interface/xen.h b/include/xen/interface/xen.h
index 40c9793e9880..f9acb21875cf 100644
--- a/include/xen/interface/xen.h
+++ b/include/xen/interface/xen.h
@@ -94,7 +94,7 @@
 #define VIRQ_XENOPROF   7  /* V. XenOprofile interrupt: new sample available */
 #define VIRQ_CON_RING   8  /* G. (DOM0) Bytes received on console            */
 #define VIRQ_PCPU_STATE 9  /* G. (DOM0) PCPU state changed                   */
-#define VIRQ_MEM_EVENT  10 /* G. (DOM0) A memory event has occured           */
+#define VIRQ_MEM_EVENT  10 /* G. (DOM0) A memory event has occurred
        */
 #define VIRQ_XC_RESERVED 11 /* G. Reserved for XenClient                     */
 #define VIRQ_ENOMEM     12 /* G. (DOM0) Low on heap memory       */
 #define VIRQ_XENPMU     13  /* PMC interrupt                                 */
-- 
2.54.0.windows.1

Re: [PATCH] xen: fix comment typo in xen.h

Posted by Andrew Cooper 1 week, 1 day ago

On 15/09/2026 2:56 pm, Ruslan Vagner wrote:
> Fix the spelling in comments. No functional change.
>
> Signed-off-by: Ruslan Vagner <rusya92266@gmail.com>
> ---
>  include/xen/interface/xen.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/xen/interface/xen.h b/include/xen/interface/xen.h
> index 40c9793e9880..f9acb21875cf 100644
> --- a/include/xen/interface/xen.h
> +++ b/include/xen/interface/xen.h
> @@ -94,7 +94,7 @@
>  #define VIRQ_XENOPROF   7  /* V. XenOprofile interrupt: new sample available */
>  #define VIRQ_CON_RING   8  /* G. (DOM0) Bytes received on console            */
>  #define VIRQ_PCPU_STATE 9  /* G. (DOM0) PCPU state changed                   */
> -#define VIRQ_MEM_EVENT  10 /* G. (DOM0) A memory event has occured           */
> +#define VIRQ_MEM_EVENT  10 /* G. (DOM0) A memory event has occurred
>         */
>  #define VIRQ_XC_RESERVED 11 /* G. Reserved for XenClient                     */
>  #define VIRQ_ENOMEM     12 /* G. (DOM0) Low on heap memory       */
>  #define VIRQ_XENPMU     13  /* PMC interrupt                                 */

The change is fine, but the email is whitespace corrupted, with the
closing */ moved onto the next line.

I can fix this up on commit, but you will want to double check your
email configuration before sending further patches.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

~Andrew

Re: [PATCH] xen: fix comment typo in xen.h

Posted by Jürgen Groß 1 week ago

On 16.09.26 14:07, Andrew Cooper wrote:
> On 15/09/2026 2:56 pm, Ruslan Vagner wrote:
>> Fix the spelling in comments. No functional change.
>>
>> Signed-off-by: Ruslan Vagner <rusya92266@gmail.com>
>> ---
>>   include/xen/interface/xen.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/xen/interface/xen.h b/include/xen/interface/xen.h
>> index 40c9793e9880..f9acb21875cf 100644
>> --- a/include/xen/interface/xen.h
>> +++ b/include/xen/interface/xen.h
>> @@ -94,7 +94,7 @@
>>   #define VIRQ_XENOPROF   7  /* V. XenOprofile interrupt: new sample available */
>>   #define VIRQ_CON_RING   8  /* G. (DOM0) Bytes received on console            */
>>   #define VIRQ_PCPU_STATE 9  /* G. (DOM0) PCPU state changed                   */
>> -#define VIRQ_MEM_EVENT  10 /* G. (DOM0) A memory event has occured           */
>> +#define VIRQ_MEM_EVENT  10 /* G. (DOM0) A memory event has occurred
>>          */
>>   #define VIRQ_XC_RESERVED 11 /* G. Reserved for XenClient                     */
>>   #define VIRQ_ENOMEM     12 /* G. (DOM0) Low on heap memory       */
>>   #define VIRQ_XENPMU     13  /* PMC interrupt                                 */
> 
> The change is fine, but the email is whitespace corrupted, with the
> closing */ moved onto the next line.
> 
> I can fix this up on commit, but you will want to double check your
> email configuration before sending further patches.
> 
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Andrew, you are aware that this is a Linux kernel patch?

just saying...

Ruslan, you should send kernel patches with the related maintainer (in this case
me) added as Cc:

As this header file is a slightly modified copy of the related header of the Xen
hypervisor project, a similar patch might be wanted for Xen, too.

That said,

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen