Hi Julien,

Thanks for your prompt response and your time on the review!

> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of
> MPU work
> 
> Hi,
> 
> On 01/08/2023 04:44, Henry Wang wrote:
> > Based on the discussion in the Xen Summit [1], sending this series out after
> > addressing the comments in v3 [2] as the preparation work to add MPU
> support.
> >
> > Mostly code movement, with some of Kconfig and build system (mainly
> Makefiles)
> > adjustment. No functional change expected.
> 
> I can't really review this series without knowing how this will
> integrate with the rest of the MPU work. 

Sorry about it, I should have asked before sending the series.

> Can you at least provide a tree
> with all the patches applied (including the MPU one)?

See [1] for the full single core MPU implementation which I've verified
locally about the MMU and MPU single core Linux boot on FVP, and
looks like Gitlab is also not complaining [2].

Note that I've addressed comments from you and Ayan in v3 about the
MMU/MPU helpers duplication and the arm32/arm64 split work. I didn't
address the comment in [3] about the RES0 stuff, but I think this is not
related to the MMU split series I sent yesterday to mailing list and the
formal v4 MPU work sent to the mailing list will contain the fix for this
comment.

[1] https://gitlab.com/xen-project/people/henryw/xen/-/commits/mpu_v4
[2] https://gitlab.com/xen-project/people/henryw/xen/-/pipelines/952742025
[3] https://patchwork.kernel.org/project/xen-devel/patch/20230626033443.2943270-32-Penny.Zheng@arm.com/

Kind regards,
Henry

> 
> Cheers,
> 
> --
> Julien Grall

On 02/08/2023 04:59, Henry Wang wrote:
> Hi Julien,

Hi Henry,

-----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: Re: [PATCH v4 00/13] xen/arm: Split MMU code as the prepration of
>> MPU work
>>
>> Hi,
>>
>> On 01/08/2023 04:44, Henry Wang wrote:
>>> Based on the discussion in the Xen Summit [1], sending this series out after
>>> addressing the comments in v3 [2] as the preparation work to add MPU
>> support.
>>>
>>> Mostly code movement, with some of Kconfig and build system (mainly
>> Makefiles)
>>> adjustment. No functional change expected.
>>
>> I can't really review this series without knowing how this will
>> integrate with the rest of the MPU work.
> 
> Sorry about it, I should have asked before sending the series.
> 
>> Can you at least provide a tree
>> with all the patches applied (including the MPU one)?
> 
> See [1] for the full single core MPU implementation which I've verified
> locally about the MMU and MPU single core Linux boot on FVP, and
> looks like Gitlab is also not complaining [2].

Thanks for the link!

> 
> Note that I've addressed comments from you and Ayan in v3 about the
> MMU/MPU helpers duplication and the arm32/arm64 split work. I didn't
> address the comment in [3] about the RES0 stuff, but I think this is not
> related to the MMU split series I sent yesterday to mailing list and the
> formal v4 MPU work sent to the mailing list will contain the fix for this
> comment.

Agree, the RES0 bit is MPU specific.

Cheers,

-- 
Julien Grall