RE: [PATCH 0/8] docs/process: branching-checklist: Update it

Posted by Henry Wang 1 year, 4 months ago

Hi Julien,

> -----Original Message-----
> From: Julien Grall <julien@xen.org>
> Subject: [PATCH 0/8] docs/process: branching-checklist: Update it
> 
> From: Julien Grall <jgrall@amazon.com>
> 
> Hi all,
> 
> This is a collection of improvement for the branching checklist.

Thanks for this work! Since from the docs/process/RUBRIC we are having:
```
They are living documents, and no special approval is needed to modify
them beyond the usual acks for commit.  They should be updated as and
when it seems expediant.
```

I don't know if my reviewed-by counts but I did go through the whole
series, so for the whole series:

Reviewed-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry

> 
> Cheers,
> 
> Julien Grall (8):
>   docs/process: branching-checklist: Use consistent indentation
>   docs/process: branching-checklist: Remove reference to qemu-ijw.git
>   docs/process: branching-checklist: Remove reference to root
>   docs/process: branching-checklist: Clarify steps to add the branch in
>     osstest
>   docs/process: branching-checklist: Reword the section about Config.mk
>   docs/process: branching-checklist: Remove section about the cambridge
>     colo
>   docs/proces: branching-checklist: Update the section "add to patchbot"
>   docs/process: branching-checklist: Add a list of accounts at the
>     beginning
> 
>  docs/process/branching-checklist.txt | 122 +++++++++++++--------------
>  1 file changed, 60 insertions(+), 62 deletions(-)
> 
> --
> 2.38.1

Re: [PATCH 0/8] docs/process: branching-checklist: Update it

Posted by Julien Grall 1 year, 2 months ago

On 12/12/2022 09:49, Henry Wang wrote:
> Hi Julien,

Hi Henry,

Sorry for the late reply.

>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: [PATCH 0/8] docs/process: branching-checklist: Update it
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> Hi all,
>>
>> This is a collection of improvement for the branching checklist.
> 
> Thanks for this work! Since from the docs/process/RUBRIC we are having:
> ```
> They are living documents, and no special approval is needed to modify
> them beyond the usual acks for commit.  They should be updated as and
> when it seems expediant.
> ```
> 
> I don't know if my reviewed-by counts but I did go through the whole
> series, so for the whole series:
> 
> Reviewed-by: Henry Wang <Henry.Wang@arm.com>

All reviews count :). Thanks for looking through them. I have added your 
tag to all but one which needs a respin.

> 
> Kind regards,
> Henry
> 
>>
>> Cheers,
>>
>> Julien Grall (8):
>>    docs/process: branching-checklist: Use consistent indentation
>>    docs/process: branching-checklist: Remove reference to qemu-ijw.git
>>    docs/process: branching-checklist: Remove reference to root
>>    docs/process: branching-checklist: Clarify steps to add the branch in
>>      osstest

I have committed up to this patch.

>>    docs/process: branching-checklist: Reword the section about Config.mk
>>    docs/process: branching-checklist: Remove section about the cambridge
>>      colo
>>    docs/proces: branching-checklist: Update the section "add to patchbot"
>>    docs/process: branching-checklist: Add a list of accounts at the
>>      beginning
>>
>>   docs/process/branching-checklist.txt | 122 +++++++++++++--------------
>>   1 file changed, 60 insertions(+), 62 deletions(-)
>>
>> --
>> 2.38.1
> 

Cheers,

-- 
Julien Grall

Re: [PATCH 0/8] docs/process: branching-checklist: Update it

Posted by Jan Beulich 1 year, 4 months ago

On 12.12.2022 10:49, Henry Wang wrote:
>> -----Original Message-----
>> From: Julien Grall <julien@xen.org>
>> Subject: [PATCH 0/8] docs/process: branching-checklist: Update it
>>
>> From: Julien Grall <jgrall@amazon.com>
>>
>> This is a collection of improvement for the branching checklist.
> 
> Thanks for this work! Since from the docs/process/RUBRIC we are having:
> ```
> They are living documents, and no special approval is needed to modify
> them beyond the usual acks for commit.  They should be updated as and
> when it seems expediant.
> ```
> 
> I don't know if my reviewed-by counts but I did go through the whole
> series, so for the whole series:
> 
> Reviewed-by: Henry Wang <Henry.Wang@arm.com>

Why should it not count? Thanks for taking the time to look through
this series.

>> Julien Grall (8):
>>   docs/process: branching-checklist: Use consistent indentation
>>   docs/process: branching-checklist: Remove reference to qemu-ijw.git
>>   docs/process: branching-checklist: Remove reference to root
>>   docs/process: branching-checklist: Clarify steps to add the branch in
>>     osstest
>>   docs/process: branching-checklist: Reword the section about Config.mk
>>   docs/process: branching-checklist: Remove section about the cambridge
>>     colo
>>   docs/proces: branching-checklist: Update the section "add to patchbot"

Just one nit here: The subject prefix could do with adding the missing 's'.

Jan

>>   docs/process: branching-checklist: Add a list of accounts at the
>>     beginning
>>
>>  docs/process/branching-checklist.txt | 122 +++++++++++++--------------
>>  1 file changed, 60 insertions(+), 62 deletions(-)