Hi Julien, > -----Original Message----- > From: Julien Grall <julien@xen.org> > Subject: Re: [PATCH v2 0/4] tools/xenstore: add some new features to the > documentation > > Hi Jan, > > On 18/07/2022 17:12, Jan Beulich wrote: > > On 27.05.2022 09:24, Juergen Gross wrote: > >> > >> Changes in V2: > >> - added new patch 1 > >> - remove feature bits for dom0-only features > >> - get-features without domid returns Xenstore supported features > >> - get/set-quota without domid for global quota access > >> > >> Juergen Gross (4): > >> tools/xenstore: modify feature bit specification in xenstore-ring.txt > >> tools/xenstore: add documentation for new set/get-feature commands > >> tools/xenstore: add documentation for new set/get-quota commands > >> tools/xenstore: add documentation for extended watch command > > > > Hmm, looks like I did commit v1 of this series, not noticing the v2 _and_ > > seeing there had been R-b with no other follow-up (leaving aside the v2) > > in a long time. Please advise if I should revert the commits. I'm sorry > > for the confusion. (I also wonder why the R-b weren't carried over to v2.) > > patch #1 is a new patch. The patch #2, #3, #4 have been reworded and the > overall interaction is different. So I don't think the reviewed-by > should have been carried. > > I had some concerns in v1 which were addressed in v2. I have reviewed v2 > a while ago. From my perspective, patch #1, #3, #4 are ready to go. > Patch #2 needs a respin and we also need to clarify the integration with > migration/live-update. > > As you committed, I would be OK if this is addressed in a follow-up > series. But this *must* be addressed by the time 4.17 is released > because otherwise we will commit ourself to a broken interface. @Henry, > please add this in the blocker list. Thank you very much for this information. I've added this in blocker list. I will keep that in mind and send (proper) reminders during the timeline of the 4.17 release process. Kind regards, Henry > > Cheers, > > -- > Julien Grall
© 2016 - 2024 Red Hat, Inc.