[PATCH] Arm32: restore proper name of .dtb section start symbol

Jan Beulich posted 1 patch 1 year, 9 months ago
Failed in applying to current master (apply log)
[PATCH] Arm32: restore proper name of .dtb section start symbol
Posted by Jan Beulich 1 year, 9 months ago
This addresses a build failure when CONFIG_DTB_FILE evaluates to a non-
empty string.

Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the physical address of a symbol")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Of course this really would be a prime candidate for avoiding the
use of linker-script-defined symbols in the first place, by using
.startof.(.dtb). If only Clang also supported that ...

--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -162,7 +162,7 @@ past_zImage:
 
         /* Using the DTB in the .dtb section? */
 .ifnes CONFIG_DTB_FILE,""
-        load_paddr r8, _stdb
+        load_paddr r8, _sdtb
 .endif
 
         /* Initialize the UART if earlyprintk has been enabled. */
Re: [PATCH] Arm32: restore proper name of .dtb section start symbol
Posted by Bertrand Marquis 1 year, 9 months ago
Hi Jan,

> On 25 Jul 2022, at 11:12, Jan Beulich <jbeulich@suse.com> wrote:
> 
> This addresses a build failure when CONFIG_DTB_FILE evaluates to a non-
> empty string.
> 
> Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the physical address of a symbol")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>

Cheers
Bertrand

> ---
> Of course this really would be a prime candidate for avoiding the
> use of linker-script-defined symbols in the first place, by using
> .startof.(.dtb). If only Clang also supported that ...
> 
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -162,7 +162,7 @@ past_zImage:
> 
>         /* Using the DTB in the .dtb section? */
> .ifnes CONFIG_DTB_FILE,""
> -        load_paddr r8, _stdb
> +        load_paddr r8, _sdtb
> .endif
> 
>         /* Initialize the UART if earlyprintk has been enabled. */