[Xen-devel] [PATCH 0/2] tools/xen-cpuid: two small adjustments

Jan Beulich posted 2 patches 2 weeks ago
Only 0 patches received!

[Xen-devel] [PATCH 0/2] tools/xen-cpuid: two small adjustments

Posted by Jan Beulich 2 weeks ago
1: MAINTAINERS: add tools/misc/xen-cpuid to "X86 ARCHITECTURE"
2: tools/xen-cpuid: avoid producing bogus output

They're not overly important to have for 4.13, but they're also rather
low risk, so I think they're worthwhile considering at this point in
time.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/2] tools/xen-cpuid: two small adjustments

Posted by Andrew Cooper 2 weeks ago
On 02/10/2019 08:27, Jan Beulich wrote:
> 1: MAINTAINERS: add tools/misc/xen-cpuid to "X86 ARCHITECTURE"
> 2: tools/xen-cpuid: avoid producing bogus output
>
> They're not overly important to have for 4.13, but they're also rather
> low risk, so I think they're worthwhile considering at this point in
> time.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

In some copious free time, I was planning to rewrite xen-cpuid in python
so we give it more interesting functionality, including "given two
policies, are they compatible", and part of that includes getting
individual policies at a time.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/2] tools/xen-cpuid: two small adjustments

Posted by Wei Liu 2 weeks ago
On Wed, Oct 02, 2019 at 09:27:07AM +0200, Jan Beulich wrote:
> 1: MAINTAINERS: add tools/misc/xen-cpuid to "X86 ARCHITECTURE"
> 2: tools/xen-cpuid: avoid producing bogus output
> 
> They're not overly important to have for 4.13, but they're also rather
> low risk, so I think they're worthwhile considering at this point in
> time.

Acked-by: Wei Liu <wl@xen.org>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH 0/2] tools/xen-cpuid: two small adjustments

Posted by Jürgen Groß 2 weeks ago
On 02.10.19 09:27, Jan Beulich wrote:
> 1: MAINTAINERS: add tools/misc/xen-cpuid to "X86 ARCHITECTURE"
> 2: tools/xen-cpuid: avoid producing bogus output
> 
> They're not overly important to have for 4.13, but they're also rather
> low risk, so I think they're worthwhile considering at this point in
> time.

For the series:

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 1/2] MAINTAINERS: add tools/misc/xen-cpuid to "X86 ARCHITECTURE"

Posted by Jan Beulich 2 weeks ago
Along the lines of other x86-specific pieces under tools/.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -472,6 +472,7 @@
 F:	tools/firmware/vgabios/
 F:	tools/fuzz/cpu-policy/
 F:	tools/fuzz/x86_instruction_emulator/
+F:	tools/misc/xen-cpuid.c
 F:	tools/tests/cpu-policy/
 F:	tools/tests/x86_emulator/
 


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH 2/2] tools/xen-cpuid: avoid producing bogus output

Posted by Jan Beulich 2 weeks ago
I was (mistakenly, as - looking at the code - it's clearly not intended
to work) passing the tool "Raw" and "Host" as command line arguments.
Avoid printing just "Raw       " with not even a newline at the end in
such a case. Instead report what wasn't understood by the parsing logic.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/misc/xen-cpuid.c
+++ b/tools/misc/xen-cpuid.c
@@ -530,6 +530,15 @@ int main(int argc, char **argv)
                 break;
             }
 
+            if ( !i )
+            {
+                fprintf(stderr, "'%s' unrecognized - skipping\n", ptr);
+                continue;
+            }
+
+            if ( *ptr )
+                fprintf(stderr, "'%s' unrecognized - ignoring\n", ptr);
+
             decode_featureset(fs, i, "Raw", true);
         }
     }


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel