x86/page: fix regressions of MISRA C Rule 8.2

[XEN PATCH] x86/page: fix regressions of MISRA C Rule 8.2

Nicola Vetrini posted 1 patch 3 months, 1 week ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/9ad46ae1a1f07bdacbcd6a6befd249be95c9d5cb.1753281819.git.nicola.vetrini@bugseng.com

xen/arch/x86/include/asm/page.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[XEN PATCH] x86/page: fix regressions of MISRA C Rule 8.2

Posted by Nicola Vetrini 3 months, 1 week ago

The rule states: "Function types shall be in prototype form
with named parameters". Add missing parameter names.

Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch controlled")
Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
 xen/arch/x86/include/asm/page.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/x86/include/asm/page.h b/xen/arch/x86/include/asm/page.h
index d8e23e614c88..b53cd19f31a4 100644
--- a/xen/arch/x86/include/asm/page.h
+++ b/xen/arch/x86/include/asm/page.h
@@ -227,8 +227,8 @@ void copy_page_sse2(void *to, const void *from);
 #define copy_page(_t, _f)   copy_page_sse2(_t, _f)
 
 #ifdef CONFIG_DEBUG
-void scrub_page_hot(void *);
-void scrub_page_cold(void *);
+void scrub_page_hot(void *pg);
+void scrub_page_cold(void *pg);
 #endif
 
 /* Convert between Xen-heap virtual addresses and machine addresses. */
-- 
2.43.0

Re: [XEN PATCH] x86/page: fix regressions of MISRA C Rule 8.2

Posted by Jan Beulich 3 months, 1 week ago

On 23.07.2025 16:45, Nicola Vetrini wrote:
> The rule states: "Function types shall be in prototype form
> with named parameters". Add missing parameter names.
> 
> Fixes: 6ff0cfbfd4f7 ("mm: allow page scrubbing routine(s) to be arch controlled")
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

Can as well take your patch (see [1]), as then I can put it in right away:
Reviewed-by: Jan Beulich <jbeulich@suse.com>

Jan

[1] https://lists.xen.org/archives/html/xen-devel/2025-07/msg01682.html