To comply with MISRA C:2012 Rule 8.10 ("An inline function shall be
declared with the static storage class"), remove inline function
specifier from handle_ro_raz() since asking the compiler to inline
such function does not seem to add any kind of value.
Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
xen/arch/arm/traps.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c
index f6437f6aa9..ef5c6a8195 100644
--- a/xen/arch/arm/traps.c
+++ b/xen/arch/arm/traps.c
@@ -1677,11 +1677,11 @@ void handle_ro_read_val(struct cpu_user_regs *regs,
}
/* Read only as read as zero */
-inline void handle_ro_raz(struct cpu_user_regs *regs,
- int regidx,
- bool read,
- const union hsr hsr,
- int min_el)
+void handle_ro_raz(struct cpu_user_regs *regs,
+ int regidx,
+ bool read,
+ const union hsr hsr,
+ int min_el)
{
handle_ro_read_val(regs, regidx, read, hsr, min_el, 0);
}
--
2.34.1
Hi Federico, NIT: for Arm, we use "xen/arm: " as a component name in a commit title or if you want to also specify the sub component, then "xen/arm: <subcomponent>: " e.g. "xen/arm: traps: " On 15/06/2023 15:50, Federico Serafini wrote: > > > To comply with MISRA C:2012 Rule 8.10 ("An inline function shall be > declared with the static storage class"), remove inline function > specifier from handle_ro_raz() since asking the compiler to inline > such function does not seem to add any kind of value. > > Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> Reviewed-by: Michal Orzel <michal.orzel@amd.com> ~Michal
Hi, On 15/06/2023 15:49, Michal Orzel wrote: > Hi Federico, > > NIT: for Arm, we use "xen/arm: " as a component name in a commit title or if you want to also specify > the sub component, then "xen/arm: <subcomponent>: " e.g. "xen/arm: traps: " > > On 15/06/2023 15:50, Federico Serafini wrote: >> >> >> To comply with MISRA C:2012 Rule 8.10 ("An inline function shall be >> declared with the static storage class"), remove inline function >> specifier from handle_ro_raz() since asking the compiler to inline >> such function does not seem to add any kind of value. >> >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com> > Reviewed-by: Michal Orzel <michal.orzel@amd.com> Acked-by: Julien Grall <jgrall@amazon.com> I will update the title while committing. Cheers, -- Julien Grall
© 2016 - 2024 Red Hat, Inc.