x86/mem_access: address violations of MISRA C:2012 Rule 8.3

[XEN PATCH] x86/mem_access: address violations of MISRA C:2012 Rule 8.3

Federico Serafini posted 1 patch 7 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/98bfdda2d3aa12c68a4be86535a6f39e6167a8e5.1695803386.git.federico.serafini@bugseng.com

xen/arch/x86/include/asm/mem_access.h | 2 +-
xen/arch/x86/mm/mem_access.c          | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

Expand all Fold all

[XEN PATCH] x86/mem_access: address violations of MISRA C:2012 Rule 8.3

Posted by Federico Serafini 7 months ago

Make function declarations and definitions consistent.
No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/arch/x86/include/asm/mem_access.h | 2 +-
 xen/arch/x86/mm/mem_access.c          | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/include/asm/mem_access.h b/xen/arch/x86/include/asm/mem_access.h
index 8957e1181c..1a52a10322 100644
--- a/xen/arch/x86/include/asm/mem_access.h
+++ b/xen/arch/x86/include/asm/mem_access.h
@@ -39,7 +39,7 @@ int p2m_set_suppress_ve(struct domain *d, gfn_t gfn, bool suppress_ve,
 
 struct xen_hvm_altp2m_suppress_ve_multi;
 int p2m_set_suppress_ve_multi(struct domain *d,
-                              struct xen_hvm_altp2m_suppress_ve_multi *suppress_ve);
+                              struct xen_hvm_altp2m_suppress_ve_multi *sve);
 
 int p2m_get_suppress_ve(struct domain *d, gfn_t gfn, bool *suppress_ve,
                         unsigned int altp2m_idx);
diff --git a/xen/arch/x86/mm/mem_access.c b/xen/arch/x86/mm/mem_access.c
index c472fa1ee5..3449e0ee85 100644
--- a/xen/arch/x86/mm/mem_access.c
+++ b/xen/arch/x86/mm/mem_access.c
@@ -70,7 +70,7 @@ static int _p2m_get_mem_access(struct p2m_domain *p2m, gfn_t gfn,
 }
 
 bool p2m_mem_access_emulate_check(struct vcpu *v,
-                                  const vm_event_response_t *rsp)
+                                  const struct vm_event_st *rsp)
 {
     xenmem_access_t access;
     bool violation = true;
@@ -129,7 +129,7 @@ bool p2m_mem_access_emulate_check(struct vcpu *v,
 
 bool p2m_mem_access_check(paddr_t gpa, unsigned long gla,
                           struct npfec npfec,
-                          vm_event_request_t **req_ptr)
+                          struct vm_event_st **req_ptr)
 {
     struct vcpu *v = current;
     gfn_t gfn = gaddr_to_gfn(gpa);
-- 
2.34.1

Re: [XEN PATCH] x86/mem_access: address violations of MISRA C:2012 Rule 8.3

Posted by Henry Wang 7 months ago

Hi Federico,

> On Sep 27, 2023, at 16:41, Federico Serafini <federico.serafini@bugseng.com> wrote:
> 
> Make function declarations and definitions consistent.
> No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

This looks like a harmless change so with proper review:

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry