[XEN PATCH] eclair: remove wrongly added -eval_file

Simone Ballarin posted 1 patch 2 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/976ea35a8682adb2991d249a48bb2b41e834e4e6.1707482589.git.simone.ballarin@bugseng.com
automation/eclair_analysis/ECLAIR/analysis.ecl | 1 -
1 file changed, 1 deletion(-)
[XEN PATCH] eclair: remove wrongly added -eval_file
Posted by Simone Ballarin 2 months, 3 weeks ago
properties.ecl does not exist and it is not
even generated by propertyparser.py. Loading
this file causes empty ECLAIR analysis.

Fixes: f4519ee8 ("eclair: move function and macro properties outside ECLAIR")
Signed-off-by: Simone Ballarin <simone.ballarin@bugseng.com>
---
 automation/eclair_analysis/ECLAIR/analysis.ecl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/automation/eclair_analysis/ECLAIR/analysis.ecl b/automation/eclair_analysis/ECLAIR/analysis.ecl
index 684c5b0b39..a604582da3 100644
--- a/automation/eclair_analysis/ECLAIR/analysis.ecl
+++ b/automation/eclair_analysis/ECLAIR/analysis.ecl
@@ -30,7 +30,6 @@ if(not(scheduled_analysis),
 -eval_file=deviations.ecl
 -eval_file=call_properties.ecl
 -eval_file=tagging.ecl
--eval_file=properties.ecl
 -eval_file=concat(set,".ecl")
 
 -doc="Hide reports in external code."
-- 
2.34.1
Re: [XEN PATCH] eclair: remove wrongly added -eval_file
Posted by Stefano Stabellini 2 months, 3 weeks ago
On Fri, 8 Feb 2024, Simone Ballarin wrote:
> properties.ecl does not exist and it is not
> even generated by propertyparser.py. Loading
> this file causes empty ECLAIR analysis.
> 
> Fixes: f4519ee8 ("eclair: move function and macro properties outside ECLAIR")
> Signed-off-by: Simone Ballarin <simone.ballarin@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  automation/eclair_analysis/ECLAIR/analysis.ecl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/analysis.ecl b/automation/eclair_analysis/ECLAIR/analysis.ecl
> index 684c5b0b39..a604582da3 100644
> --- a/automation/eclair_analysis/ECLAIR/analysis.ecl
> +++ b/automation/eclair_analysis/ECLAIR/analysis.ecl
> @@ -30,7 +30,6 @@ if(not(scheduled_analysis),
>  -eval_file=deviations.ecl
>  -eval_file=call_properties.ecl
>  -eval_file=tagging.ecl
> --eval_file=properties.ecl
>  -eval_file=concat(set,".ecl")
>  
>  -doc="Hide reports in external code."
> -- 
> 2.34.1
>