[XEN PATCH v2] xen/sort: address violations of MISRA C:2012 Rule 8.2

Federico Serafini posted 1 patch 5 months, 1 week ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/8b84bea9a52d9ae60fc355855bcb046ac5f24686.1700740128.git.federico.serafini@bugseng.com
xen/include/xen/sort.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[XEN PATCH v2] xen/sort: address violations of MISRA C:2012 Rule 8.2
Posted by Federico Serafini 5 months, 1 week ago
Add missing parameter names. No functional change.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
Changes in v2:
  - used "a" and "b" for cmp.
---
 xen/include/xen/sort.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/include/xen/sort.h b/xen/include/xen/sort.h
index 2f52ff85b9..b953286284 100644
--- a/xen/include/xen/sort.h
+++ b/xen/include/xen/sort.h
@@ -23,8 +23,8 @@
 extern gnu_inline
 #endif
 void sort(void *base, size_t num, size_t size,
-          int (*cmp)(const void *, const void *),
-          void (*swap)(void *, void *, size_t))
+          int (*cmp)(const void *a, const void *b),
+          void (*swap)(void *a, void *b, size_t size))
 {
     /* pre-scale counters for performance */
     size_t i = (num / 2) * size, n = num * size, c, r;
-- 
2.34.1
Re: [XEN PATCH v2] xen/sort: address violations of MISRA C:2012 Rule 8.2
Posted by Jan Beulich 5 months, 1 week ago
On 23.11.2023 13:39, Federico Serafini wrote:
> Add missing parameter names. No functional change.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Jan Beulich <jbeulich@suse.com>