[PATCH] x86/CPU: correct reset_cpuinfo() comment

Jan Beulich posted 1 patch 3 months, 1 week ago
Failed in applying to current master (apply log)
[PATCH] x86/CPU: correct reset_cpuinfo() comment
Posted by Jan Beulich 3 months, 1 week ago
Part of it stated the opposite of what actual behavior is.

Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")
Reported-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/include/asm/cpufeature.h
+++ b/xen/arch/x86/include/asm/cpufeature.h
@@ -91,8 +91,8 @@ struct cpuinfo_x86 {
 
 /*
  * @keep_basic set to true retains data firmly assumed to be symmetric
- * across all CPUs.  With it set to false only CPU_DATA_INIT() will be
- * invoked on the passed structure.
+ * across all CPUs.  Only CPU_DATA_INIT() will be invoked in that case
+ * on the passed structure.
  */
 void reset_cpuinfo(struct cpuinfo_x86 *c, bool keep_basic);
Re: [PATCH] x86/CPU: correct reset_cpuinfo() comment
Posted by Roger Pau Monné 2 months, 3 weeks ago
On Wed, Jul 23, 2025 at 02:00:55PM +0200, Jan Beulich wrote:
> Part of it stated the opposite of what actual behavior is.
> 
> Fixes: 7126b7f806d5 ("x86/CPU: re-work populating of cpu_data[]")
> Reported-by: Juergen Gross <jgross@suse.com>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

Thanks, Roger.