x86emul/test: correct VRNDSCALES{S,D} entries in predicates test

[PATCH] x86emul/test: correct VRNDSCALES{S,D} entries in predicates test

Posted by Jan Beulich 2 years, 2 months ago

While benign (because only the decoder is exercised here, whereas a
wrong EVEX.W would cause an exception only during actual emulation),
let's still have correct information in the table entries.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/tools/tests/x86_emulator/predicates.c
+++ b/tools/tests/x86_emulator/predicates.c
@@ -1974,8 +1974,8 @@ static const struct evex {
     { { 0x05 }, 3, T, R, pfx_66, W1, Ln }, /* vpermilpd */
     { { 0x08 }, 3, T, R, pfx_66, W0, Ln }, /* vrndscaleps */
     { { 0x09 }, 3, T, R, pfx_66, W1, Ln }, /* vrndscalepd */
-    { { 0x0a }, 3, T, R, pfx_66, WIG, LIG }, /* vrndscaless */
-    { { 0x0b }, 3, T, R, pfx_66, WIG, LIG }, /* vrndscalesd */
+    { { 0x0a }, 3, T, R, pfx_66, W0, LIG }, /* vrndscaless */
+    { { 0x0b }, 3, T, R, pfx_66, W1, LIG }, /* vrndscalesd */
     { { 0x0f }, 3, T, R, pfx_66, WIG, Ln }, /* vpalignr */
     { { 0x14 }, 3, T, W, pfx_66, WIG, L0 }, /* vpextrb */
     { { 0x15 }, 3, T, W, pfx_66, WIG, L0 }, /* vpextrw */

Re: [PATCH] x86emul/test: correct VRNDSCALES{S,D} entries in predicates test

Posted by Andrew Cooper 2 years, 2 months ago

On 03/03/2022 16:48, Jan Beulich wrote:
> While benign (because only the decoder is exercised here, whereas a
> wrong EVEX.W would cause an exception only during actual emulation),
> let's still have correct information in the table entries.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>