xen/arm: ioreq: add header for 'handle_ioserv' and 'try_fwd_ioserv'

[XEN PATCH v2] xen/arm: ioreq: add header for 'handle_ioserv' and 'try_fwd_ioserv'

Nicola Vetrini posted 1 patch 7 months, 3 weeks ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/7a58fd2e4361de53fc81475dd4aca52a57b770f1.1693581823.git.nicola.vetrini@bugseng.com

xen/arch/arm/ioreq.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[XEN PATCH v2] xen/arm: ioreq: add header for 'handle_ioserv' and 'try_fwd_ioserv'

Posted by Nicola Vetrini 7 months, 3 weeks ago

The functions referenced by this patch should have had a compatible
declaration visible prior to their definition. This is achieved by
including the arch-specific header in 'xen/arch/arm/ioreq.c'

Fixes: cb9953d2f2bc ("arm/ioreq: Introduce arch specific bits for IOREQ/DM features")
Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
Changes in v2:
- Avoid including <asm/ioreq.h> in <xen/ioreq.h> to allow new architectures
  (e.g. ppc and riscv) not to provide one more stub header,
  as pointed out by Jan Beulich.
---
 xen/arch/arm/ioreq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
index 55854571898d..3bed0a14c050 100644
--- a/xen/arch/arm/ioreq.c
+++ b/xen/arch/arm/ioreq.c
@@ -9,6 +9,7 @@
 #include <xen/ioreq.h>

 #include <asm/traps.h>
+#include <asm/ioreq.h>

 #include <public/hvm/ioreq.h>

--
2.34.1

Re: [XEN PATCH v2] xen/arm: ioreq: add header for 'handle_ioserv' and 'try_fwd_ioserv'

Posted by Stefano Stabellini 7 months, 3 weeks ago

On Mon, 4 Sep 2023, Nicola Vetrini wrote:
> The functions referenced by this patch should have had a compatible
> declaration visible prior to their definition. This is achieved by
> including the arch-specific header in 'xen/arch/arm/ioreq.c'
> 
> Fixes: cb9953d2f2bc ("arm/ioreq: Introduce arch specific bits for IOREQ/DM features")
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
> Changes in v2:
> - Avoid including <asm/ioreq.h> in <xen/ioreq.h> to allow new architectures
>   (e.g. ppc and riscv) not to provide one more stub header,
>   as pointed out by Jan Beulich.
> ---
>  xen/arch/arm/ioreq.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/xen/arch/arm/ioreq.c b/xen/arch/arm/ioreq.c
> index 55854571898d..3bed0a14c050 100644
> --- a/xen/arch/arm/ioreq.c
> +++ b/xen/arch/arm/ioreq.c
> @@ -9,6 +9,7 @@
>  #include <xen/ioreq.h>
> 
>  #include <asm/traps.h>
> +#include <asm/ioreq.h>
> 
>  #include <public/hvm/ioreq.h>
> 
> --
> 2.34.1
>