x86/boot: properly "ignore" early evaluated "no-real-mode"

[PATCH] x86/boot: properly "ignore" early evaluated "no-real-mode"

Posted by Jan Beulich 4 years, 4 months ago

The option parser takes off "no-" prefixes before matching, so they also
shouldn't be specified to match against.

Fixes: e44d98608476 ("x86/setup: Ignore early boot parameters like no-real-mode")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -692,7 +692,7 @@ static void __init noreturn reinit_bsp_s
  * has options that are only used during the very initial boot process,
  * so they can be ignored now.
  */
-ignore_param("no-real-mode");
+ignore_param("real-mode");
 ignore_param("edd");
 ignore_param("edid");

Re: [PATCH] x86/boot: properly "ignore" early evaluated "no-real-mode"

Posted by Andrew Cooper 4 years, 4 months ago

On 13/09/2021 17:02, Jan Beulich wrote:
> The option parser takes off "no-" prefixes before matching, so they also
> shouldn't be specified to match against.
>
> Fixes: e44d98608476 ("x86/setup: Ignore early boot parameters like no-real-mode")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Oops.

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

>
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -692,7 +692,7 @@ static void __init noreturn reinit_bsp_s
>   * has options that are only used during the very initial boot process,
>   * so they can be ignored now.
>   */
> -ignore_param("no-real-mode");
> +ignore_param("real-mode");
>  ignore_param("edd");
>  ignore_param("edid");
>  
>