[PATCH] x86/PVH: mark pvh_setup_mmcfg() __init

Jan Beulich posted 1 patch 4 weeks, 1 day ago
Failed in applying to current master (apply log)
[PATCH] x86/PVH: mark pvh_setup_mmcfg() __init
Posted by Jan Beulich 4 weeks, 1 day ago
Its sole caller is, and the wrong annotation would cause a build failure
(non-empty .text) if the compiler chose to not inline the function when at
the same time LATE_HWDOM=y.

Fixes: be52cb139f57a ("x86/mmcfg: add handlers for the PVH Dom0 MMCFG areas")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/hvm/dom0_build.c
+++ b/xen/arch/x86/hvm/dom0_build.c
@@ -1310,7 +1310,7 @@ static int __init pvh_setup_acpi(struct
     return 0;
 }
 
-static void __hwdom_init pvh_setup_mmcfg(struct domain *d)
+static void __init pvh_setup_mmcfg(struct domain *d)
 {
     unsigned int i;
     int rc;
Re: [PATCH] x86/PVH: mark pvh_setup_mmcfg() __init
Posted by Roger Pau Monné 4 weeks, 1 day ago
On Thu, Jan 08, 2026 at 10:16:55AM +0100, Jan Beulich wrote:
> Its sole caller is, and the wrong annotation would cause a build failure
> (non-empty .text) if the compiler chose to not inline the function when at
> the same time LATE_HWDOM=y.
> 
> Fixes: be52cb139f57a ("x86/mmcfg: add handlers for the PVH Dom0 MMCFG areas")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>

That was my oversight, sorry.

Thanks, Roger.