1. Patchew
  2. Xen
  3. View series

[XEN PATCH] xen: change parameter name in monitor_domctl() declaration

Federico Serafini posted 1 patch 9 months, 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com
xen/include/xen/monitor.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[XEN PATCH] xen: change parameter name in monitor_domctl() declaration
Posted by Federico Serafini 9 months, 2 weeks ago 
Change parameter name in monitor_domctl() declaration for
consistency with the corresponding definition.
This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
of an object or function shall use the same names and type qualifiers".

No functional changes.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 xen/include/xen/monitor.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
index 6b17a93071..713d54f7c1 100644
--- a/xen/include/xen/monitor.h
+++ b/xen/include/xen/monitor.h
@@ -27,7 +27,7 @@
 struct domain;
 struct xen_domctl_monitor_op;
 
-int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
+int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
 void monitor_guest_request(void);
 
 int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
-- 
2.34.1
Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
Posted by Stefano Stabellini 9 months, 1 week ago 
Hi Tamas,

May I have your ack on this change?


On Thu, 27 Jul 2023, Federico Serafini wrote:
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> of an object or function shall use the same names and type qualifiers".
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  xen/include/xen/monitor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
> index 6b17a93071..713d54f7c1 100644
> --- a/xen/include/xen/monitor.h
> +++ b/xen/include/xen/monitor.h
> @@ -27,7 +27,7 @@
>  struct domain;
>  struct xen_domctl_monitor_op;
>  
> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
>  void monitor_guest_request(void);
>  
>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
> -- 
> 2.34.1
> 
>
Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
Posted by Jan Beulich 9 months ago 
On 04.08.2023 23:39, Stefano Stabellini wrote:
> Hi Tamas,
> 
> May I have your ack on this change?

I see you committed this, and there is an ack in the commit, but I can't
see any ack on list (incl when checking mail archives, to exclude an
issue with my mailbox).

Jan

> On Thu, 27 Jul 2023, Federico Serafini wrote:
>> Change parameter name in monitor_domctl() declaration for
>> consistency with the corresponding definition.
>> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
>> of an object or function shall use the same names and type qualifiers".
>>
>> No functional changes.
>>
>> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> 
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> 
> 
>> ---
>>  xen/include/xen/monitor.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
>> index 6b17a93071..713d54f7c1 100644
>> --- a/xen/include/xen/monitor.h
>> +++ b/xen/include/xen/monitor.h
>> @@ -27,7 +27,7 @@
>>  struct domain;
>>  struct xen_domctl_monitor_op;
>>  
>> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
>> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
>>  void monitor_guest_request(void);
>>  
>>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
>> -- 
>> 2.34.1
>>
>>
>
Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
Posted by Stefano Stabellini 9 months ago 
On Tue, 8 Aug 2023, Jan Beulich wrote:
> On 04.08.2023 23:39, Stefano Stabellini wrote:
> > Hi Tamas,
> > 
> > May I have your ack on this change?
> 
> I see you committed this, and there is an ack in the commit, but I can't
> see any ack on list (incl when checking mail archives, to exclude an
> issue with my mailbox).

That is strange! Something appears to be wrong with xen-devel. Adding
George in CC and attaching Tamas' reply.


> > On Thu, 27 Jul 2023, Federico Serafini wrote:
> >> Change parameter name in monitor_domctl() declaration for
> >> consistency with the corresponding definition.
> >> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> >> of an object or function shall use the same names and type qualifiers".
> >>
> >> No functional changes.
> >>
> >> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > 
> > 
> >> ---
> >>  xen/include/xen/monitor.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
> >> index 6b17a93071..713d54f7c1 100644
> >> --- a/xen/include/xen/monitor.h
> >> +++ b/xen/include/xen/monitor.h
> >> @@ -27,7 +27,7 @@
> >>  struct domain;
> >>  struct xen_domctl_monitor_op;
> >>  
> >> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
> >> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
> >>  void monitor_guest_request(void);
> >>  
> >>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
> >> -- 
> >> 2.34.1
> >>
> >>
> > 
> >From tamas@tklengyel.com Sat Aug  5 04:06:33 2023
Return-Path: <SRS0=apUu=DW=tklengyel.com=bounce+b5c693.cd840-sstabellini=kernel.org@kernel.org>
Delivered-To: stefano-oss@posteo.net
Received: from posteo.de [185.67.36.169]
	by ubuntu-linux-20-04-desktop with IMAP (fetchmail-6.4.2)
	for <sstabellini@localhost> (single-drop); Sat, 05 Aug 2023 04:06:33 -0700 (PDT)
Received: from proxy02.posteo.name ([127.0.0.1])
	by dovecot15.posteo.name (Dovecot) with LMTP id OD0XKygrzmTfMAIAB3Nl4w
	for <stefano-oss@posteo.net>; Sat, 05 Aug 2023 13:06:14 +0200
Received: from proxy02.posteo.de ([127.0.0.1])
	by proxy02.posteo.name (Dovecot) with LMTP id fqefNzspzmTX4QAAGFAyLg
	; Sat, 05 Aug 2023 13:06:14 +0200
Received: from mailin02.posteo.de (unknown [10.0.0.62])
	by proxy02.posteo.de (Postfix) with ESMTPS id 4RJ0BL2G6Jz12M6
	for <stefano-oss@posteo.net>; Sat,  5 Aug 2023 13:06:02 +0200 (CEST)
Received: from mx01.posteo.de (mailin02.posteo.de [127.0.0.1])
	by mailin02.posteo.de (Postfix) with ESMTPS id 3ED26216E2
	for <stefano-oss@posteo.net>; Sat,  5 Aug 2023 13:06:02 +0200 (CEST)
X-Virus-Scanned: amavisd-new at posteo.de
X-Spam-Flag: NO
X-Spam-Score: -4.75
X-Spam-Level: 
X-Spam-Status: No, score=-4.75 tagged_above=-1000 required=5
	tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.249, HTML_MESSAGE=0.001,
	RCVD_IN_DNSWL_HI=-5, T_POSTEO_TLSINY=0.01,
	T_RCVD_IN_ABUSIX_WHITE=-0.01] autolearn=disabled
X-Posteo-Antispam-Signature: v=1; e=base64; a=aes-256-gcm; d=p4jeoLx8GSVfXysvUQMETnPVZwsS1NCfRrCQ+OIfXMVkjhIZ6cJqJzQ2xsxWawG5B4emcNKFyaO0uF37H3jKNhljpy3WUd4kJSdvfddciH4VZJrlRmkPTO3n77X06CxEC2ZK2K7g
Authentication-Results: posteo.de; dmarc=none (p=none dis=none) header.from=tklengyel.com
Authentication-Results: posteo.de; spf=pass smtp.mailfrom=kernel.org
Authentication-Results: posteo.de;
	dkim=pass (2048-bit key) header.d=tklengyel.com header.i=@tklengyel.com header.b=NZXhVc+1;
	dkim-atps=neutral
X-Posteo-TLS-Received-Status: TLSv1.3
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
	by mx01.posteo.de (Postfix) with ESMTPS id 4RJ0BK3q2Lz11g3
	for <stefano-oss@posteo.net>; Sat,  5 Aug 2023 13:06:01 +0200 (CEST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits))
	(No client certificate requested)
	by dfw.source.kernel.org (Postfix) with ESMTPS id 748A3601D0
	for <stefano-oss@posteo.net>; Sat,  5 Aug 2023 11:06:00 +0000 (UTC)
Received: by smtp.kernel.org (Postfix)
	id E997BC433C9; Sat,  5 Aug 2023 11:05:59 +0000 (UTC)
Delivered-To: sstabellini@kernel.org
Received: from so254-35.mailgun.net (so254-35.mailgun.net [198.61.254.35])
	(using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
	 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
	(No client certificate requested)
	by smtp.kernel.org (Postfix) with ESMTPS id 348A5C433C8
	for <sstabellini@kernel.org>; Sat,  5 Aug 2023 11:05:57 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 348A5C433C8
Authentication-Results: smtp.kernel.org; dmarc=none (p=none dis=none) header.from=tklengyel.com
Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=tklengyel.com
DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=tklengyel.com;
 q=dns/txt; s=mailo; t=1691233557; x=1691240757; h=Content-Type: Cc: To: To:
 Subject: Subject: Message-ID: Date: From: From: In-Reply-To: References:
 MIME-Version: Sender: Sender;
 bh=XEy1vcTg986vcuRn0cPfqtUGQoVn71aO6yXWNPsDcxk=;
 b=NZXhVc+1LvgtFz3pZo5eY/1oI+bvlQ3bB+A78sFqnfnLDKJHOLEuyKq99mzA6xhCmle23OzwhRXlfjR0LhB5pn4eVXXoV+/SIXHrUd4/yX/JPwvz03PB7MiA4ori9XJ88+EjC4BEJaniSPsz3G3hc0L/niZXBBzOJZXVCwR5K+cwaW4TECmqvXDAdvOiTkyfmU9df3JW7qSdw6+0SbtvQcTI06VFiROAHiBn2TGDwSzxYtEA43P3JHEw2zvukbN+VqO8dj6dDMAVtyYPimJ79CPesn6HYDDmsR0kTptCyFBgHLT7Gm2rFb1qoh1feNUtlH6rw4kZnH21KTHw7io5ZQ==
X-Mailgun-Sending-Ip: 198.61.254.35
X-Mailgun-Sid: WyI2MzhkZCIsInNzdGFiZWxsaW5pQGtlcm5lbC5vcmciLCJjZDg0MCJd
Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by
 aba04b98da0a with SMTP id 64ce2d1544e01654935e5a3b (version=TLS1.3,
 cipher=TLS_AES_128_GCM_SHA256); Sat, 05 Aug 2023 11:05:57 GMT
Sender: tamas@tklengyel.com
Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-586a3159588so25627287b3.0
        for <sstabellini@kernel.org>; Sat, 05 Aug 2023 04:05:57 -0700 (PDT)
X-Gm-Message-State: AOJu0YziM/EzIuEAzcUpHfY7hNhb9pGl+eZvYLzSfl2n7nkjDlH48XUp
	6O8gexWJG+sWR/f3n9EugmCpOnFYliZVhHKlcr4=
X-Google-Smtp-Source: AGHT+IHeaTodq61jc8nt4YGs/RkXrtsDT5KZst1gZHUjz80gQXJivp4tUcqwXUIDc+OnFE93Mhgqw4csAoe7ZxG3rV0=
X-Received: by 2002:a81:6c45:0:b0:586:9384:ffd7 with SMTP id
 h66-20020a816c45000000b005869384ffd7mr2473174ywc.9.1691233556109; Sat, 05 Aug
 2023 04:05:56 -0700 (PDT)
MIME-Version: 1.0
References: <6a25e9d729e85ba5712fd00f9c0514a459bb7631.1690471420.git.federico.serafini@bugseng.com>
 <alpine.DEB.2.22.394.2308041438170.2127516@ubuntu-linux-20-04-desktop>
In-Reply-To: <alpine.DEB.2.22.394.2308041438170.2127516@ubuntu-linux-20-04-desktop>
From: Tamas K Lengyel <tamas@tklengyel.com>
Date: Sat, 5 Aug 2023 13:05:44 +0200
X-Gmail-Original-Message-ID: <CABfawh=r2Ad6ZvHqjH3UpGGx2wjjuurhcOabby=Xv=E2zK0TsA@mail.gmail.com>
Message-ID: <CABfawh=r2Ad6ZvHqjH3UpGGx2wjjuurhcOabby=Xv=E2zK0TsA@mail.gmail.com>
Subject: Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, consulting@bugseng.com, 
	Alexandru Isaila <aisaila@bitdefender.com>, Petre Pircalabu <ppircalabu@bitdefender.com>, 
	Federico Serafini <federico.serafini@bugseng.com>
Content-Type: multipart/alternative; boundary="0000000000005822c306022aff56"

<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Aug 4, 2023, 11:39 PM Stefano Stabellini &lt;<a href="mailto:sstabellini@kernel.org">sstabellini@kernel.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Tamas,<br>
<br>
May I have your ack on this change?<br>
<br>
<br>
On Thu, 27 Jul 2023, Federico Serafini wrote:<br>
&gt; Change parameter name in monitor_domctl() declaration for<br>
&gt; consistency with the corresponding definition.<br>
&gt; This addresses a violation of MISRA C:2012 Rule 8.3: &quot;All declarations<br>
&gt; of an object or function shall use the same names and type qualifiers&quot;.<br>
&gt; <br>
&gt; No functional changes.<br>
&gt; <br>
&gt; Signed-off-by: Federico Serafini &lt;<a href="mailto:federico.serafini@bugseng.com" target="_blank" rel="noreferrer">federico.serafini@bugseng.com</a>&gt;<br>
<br>
Reviewed-by: Stefano Stabellini &lt;<a href="mailto:sstabellini@kernel.org" target="_blank" rel="noreferrer">sstabellini@kernel.org</a>&gt;<br></blockquote></div></div><div dir="auto"><br></div><div dir="auto">Acked-by: Tamas K Lengyel &lt;<a href="mailto:tamas@tklengyel.com">tamas@tklengyel.com</a>&gt;</div><div dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>
Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
Posted by Jan Beulich 9 months ago 
On 08.08.2023 22:15, Stefano Stabellini wrote:
> On Tue, 8 Aug 2023, Jan Beulich wrote:
>> On 04.08.2023 23:39, Stefano Stabellini wrote:
>>> Hi Tamas,
>>>
>>> May I have your ack on this change?
>>
>> I see you committed this, and there is an ack in the commit, but I can't
>> see any ack on list (incl when checking mail archives, to exclude an
>> issue with my mailbox).
> 
> That is strange! Something appears to be wrong with xen-devel. Adding
> George in CC and attaching Tamas' reply.

Yet more strange: The attachment (as it arrived here) is zero size. But
I can see it at
https://lists.xen.org/archives/html/xen-devel/2023-08/msg00959.html
Part of the reason may be that it looks to have been a HTML mail (which
it shouldn't have been).

Jan
Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
Posted by Luca Fancellu 9 months, 2 weeks ago 

> On 27 Jul 2023, at 16:35, Federico Serafini <federico.serafini@bugseng.com> wrote:
> 
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> of an object or function shall use the same names and type qualifiers".
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.