tools: make misra convert tool executable

[PATCH] tools: make misra convert tool executable

Bertrand Marquis posted 1 patch 1 year, 8 months ago

Download mbox

Test gitlab-ci failed

Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/65d730eb0543c507e76b33285bb9d3430662732b.1659444520.git.bertrand.marquis@arm.com

xen/tools/convert_misra_doc.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755 xen/tools/convert_misra_doc.py

Expand all Fold all

[PATCH] tools: make misra convert tool executable

Posted by Bertrand Marquis 1 year, 8 months ago

Fix misra document conversion script to be executable.

Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
---
 xen/tools/convert_misra_doc.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 xen/tools/convert_misra_doc.py

diff --git a/xen/tools/convert_misra_doc.py b/xen/tools/convert_misra_doc.py
old mode 100644
new mode 100755
-- 
2.25.1

Re: [PATCH] tools: make misra convert tool executable

Posted by Jan Beulich 1 year, 8 months ago

On 03.08.2022 09:35, Bertrand Marquis wrote:
> Fix misra document conversion script to be executable.
> 
> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> ---
>  xen/tools/convert_misra_doc.py | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  mode change 100644 => 100755 xen/tools/convert_misra_doc.py

Hmm, the real fix imo would be to add $(PYTHON), just like we use
$(SHELL) to invoke shell scripts. This is to cover for file systems
lacking a way to express executable permission. (Along with that I
certainly wouldn't mind the mode change, but that would then only
be for cosmetic reasons.)

Jan

Re: [PATCH] tools: make misra convert tool executable

Posted by Bertrand Marquis 1 year, 8 months ago

Hi Jan,

> On 3 Aug 2022, at 08:55, Jan Beulich <jbeulich@suse.com> wrote:
> 
> On 03.08.2022 09:35, Bertrand Marquis wrote:
>> Fix misra document conversion script to be executable.
>> 
>> Fixes: 57caa53753 (xen: Add MISRA support to cppcheck make rule)
>> Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
>> ---
>> xen/tools/convert_misra_doc.py | 0
>> 1 file changed, 0 insertions(+), 0 deletions(-)
>> mode change 100644 => 100755 xen/tools/convert_misra_doc.py
> 
> Hmm, the real fix imo would be to add $(PYTHON), just like we use
> $(SHELL) to invoke shell scripts. This is to cover for file systems
> lacking a way to express executable permission. (Along with that I
> certainly wouldn't mind the mode change, but that would then only
> be for cosmetic reasons.)

Good point, I will submit a v2 doing both.

Cheers
Bertrand

> 
> Jan