kconfig: ensure strndup() declaration is visible

[PATCH] kconfig: ensure strndup() declaration is visible

Posted by Jan Beulich 3 years, 3 months ago

Its guard was updated such that it is visible by default when POSIX 2008
was adopted by glibc. It's not visible by default on older glibc.

Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/tools/kconfig/parser.y
+++ b/xen/tools/kconfig/parser.y
@@ -4,6 +4,7 @@
  */
 %{
 
+#define _GNU_SOURCE
 #include <ctype.h>
 #include <stdarg.h>
 #include <stdio.h>

Re: [PATCH] kconfig: ensure strndup() declaration is visible

Posted by Andrew Cooper 3 years, 3 months ago

On 11/01/2021 14:42, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
>
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>

Ping: [PATCH] kconfig: ensure strndup() declaration is visible

Posted by Jan Beulich 3 years, 3 months ago

Doug,

On 11.01.2021 15:42, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
> 
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

I've got an ack from Andrew, but strictly speaking I need yours
aiui. I'll wait some more, but will commit this perhaps by mid
of the week.

Jan

Re: [PATCH] kconfig: ensure strndup() declaration is visible

Posted by Doug Goldstein 3 years, 3 months ago

On 1/11/21 8:42 AM, Jan Beulich wrote:
> Its guard was updated such that it is visible by default when POSIX 2008
> was adopted by glibc. It's not visible by default on older glibc.
> 
> Fixes: f80fe2b34f08 ("xen: Update Kconfig to Linux v5.4")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/tools/kconfig/parser.y
> +++ b/xen/tools/kconfig/parser.y
> @@ -4,6 +4,7 @@
>    */
>   %{
>   
> +#define _GNU_SOURCE
>   #include <ctype.h>
>   #include <stdarg.h>
>   #include <stdio.h>
> 

Ack-by: Doug Goldstein <cardoe@cardoe.com>