[PATCH 1/5] perfc: conditionalize credit/credit2 counters

Jan Beulich posted 5 patches 4 years, 2 months ago
[PATCH 1/5] perfc: conditionalize credit/credit2 counters
Posted by Jan Beulich 4 years, 2 months ago
There's no point including them when the respective scheduler isn't
enabled in the build.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/include/xen/perfc_defn.h
+++ b/xen/include/xen/perfc_defn.h
@@ -37,6 +37,7 @@ PERFCOUNTER(tickled_busy_cpu,       "sch
 PERFCOUNTER(unit_check,             "sched: unit_check")
 
 /* credit specific counters */
+#ifdef CONFIG_SCHED_CREDIT
 PERFCOUNTER(delay_ms,               "csched: delay")
 PERFCOUNTER(acct_run,               "csched: acct_run")
 PERFCOUNTER(acct_no_work,           "csched: acct_no_work")
@@ -58,8 +59,10 @@ PERFCOUNTER(migrate_queued,         "csc
 PERFCOUNTER(migrate_running,        "csched: migrate_running")
 PERFCOUNTER(migrate_kicked_away,    "csched: migrate_kicked_away")
 PERFCOUNTER(unit_hot,               "csched: unit_hot")
+#endif
 
 /* credit2 specific counters */
+#ifdef CONFIG_SCHED_CREDIT2
 PERFCOUNTER(burn_credits_t2c,       "csched2: burn_credits_t2c")
 PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
 PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
@@ -77,6 +80,7 @@ PERFCOUNTER(credit_reset,           "csc
 PERFCOUNTER(deferred_to_tickled_cpu,"csched2: deferred_to_tickled_cpu")
 PERFCOUNTER(tickled_cpu_overwritten,"csched2: tickled_cpu_overwritten")
 PERFCOUNTER(tickled_cpu_overridden, "csched2: tickled_cpu_overridden")
+#endif
 
 PERFCOUNTER(need_flush_tlb_flush,   "PG_need_flush tlb flushes")
 


Re: [PATCH 1/5] perfc: conditionalize credit/credit2 counters
Posted by Luca Fancellu 4 years, 2 months ago

> On 3 Dec 2021, at 12:03, Jan Beulich <jbeulich@suse.com> wrote:
> 
> There's no point including them when the respective scheduler isn't
> enabled in the build.
> 

Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>

> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> --- a/xen/include/xen/perfc_defn.h
> +++ b/xen/include/xen/perfc_defn.h
> @@ -37,6 +37,7 @@ PERFCOUNTER(tickled_busy_cpu,       "sch
> PERFCOUNTER(unit_check,             "sched: unit_check")
> 
> /* credit specific counters */
> +#ifdef CONFIG_SCHED_CREDIT
> PERFCOUNTER(delay_ms,               "csched: delay")
> PERFCOUNTER(acct_run,               "csched: acct_run")
> PERFCOUNTER(acct_no_work,           "csched: acct_no_work")
> @@ -58,8 +59,10 @@ PERFCOUNTER(migrate_queued,         "csc
> PERFCOUNTER(migrate_running,        "csched: migrate_running")
> PERFCOUNTER(migrate_kicked_away,    "csched: migrate_kicked_away")
> PERFCOUNTER(unit_hot,               "csched: unit_hot")
> +#endif
> 
> /* credit2 specific counters */
> +#ifdef CONFIG_SCHED_CREDIT2
> PERFCOUNTER(burn_credits_t2c,       "csched2: burn_credits_t2c")
> PERFCOUNTER(acct_load_balance,      "csched2: acct_load_balance")
> PERFCOUNTER(upd_max_weight_quick,   "csched2: update_max_weight_quick")
> @@ -77,6 +80,7 @@ PERFCOUNTER(credit_reset,           "csc
> PERFCOUNTER(deferred_to_tickled_cpu,"csched2: deferred_to_tickled_cpu")
> PERFCOUNTER(tickled_cpu_overwritten,"csched2: tickled_cpu_overwritten")
> PERFCOUNTER(tickled_cpu_overridden, "csched2: tickled_cpu_overridden")
> +#endif
> 
> PERFCOUNTER(need_flush_tlb_flush,   "PG_need_flush tlb flushes")
> 
> 
>