automation/eclair: tag files as "adopted" and "out of scope"

[XEN PATCH] automation/eclair: tag files as "adopted" and "out of scope"

Posted by Federico Serafini 5 months, 1 week ago

Tag arm64/efibind.h as "adopted":
it is used to build the efi stub, which is a separate entry point
for Xen when booted from EFI firmware.

Tag common/coverage/* as "out-of-scope":
it is code to support gcov, hence it is part of the testing machinery.

Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>
---
 automation/eclair_analysis/ECLAIR/out_of_scope.ecl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
index e1ec4a607c..3bd385ecf9 100644
--- a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
+++ b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
@@ -84,6 +84,7 @@
 -doc_begin="Files imported from the gnu-efi package"
 -file_tag+={adopted,"^xen/include/efi/.*$"}
 -file_tag+={adopted,"^xen/arch/x86/include/asm/x86_64/efibind\\.h$"}
+-file_tag+={adopted,"^xen/arch/arm/include/asm/arm64/efibind\\.h$"}
 -doc_end
 
 -doc_begin="Build tools are out of scope."
@@ -104,6 +105,10 @@
 -file_tag+={out_of_scope,"^xen/include/xen/xxhash\\.h$"}
 -doc_end
 
+-doc_begin="Out of scope code to support gcov."
+-file_tag+={out_of_scope, "^xen/common/coverage/.*$"}
+-doc_end
+
 -doc_begin="Headers under xen/include/public/ are the description of the public
 hypercall ABI so the community is extremely conservative in making changes
 there, because the interface is maintained for backward compatibility: ignore
-- 
2.34.1

Re: [XEN PATCH] automation/eclair: tag files as "adopted" and "out of scope"

Posted by Stefano Stabellini 5 months ago

On Fri, 24 Nov 2023, Federico Serafini wrote:
> Tag arm64/efibind.h as "adopted":
> it is used to build the efi stub, which is a separate entry point
> for Xen when booted from EFI firmware.
> 
> Tag common/coverage/* as "out-of-scope":
> it is code to support gcov, hence it is part of the testing machinery.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

I think they should be in the exclude-list ?


> ---
>  automation/eclair_analysis/ECLAIR/out_of_scope.ecl | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
> index e1ec4a607c..3bd385ecf9 100644
> --- a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
> +++ b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
> @@ -84,6 +84,7 @@
>  -doc_begin="Files imported from the gnu-efi package"
>  -file_tag+={adopted,"^xen/include/efi/.*$"}
>  -file_tag+={adopted,"^xen/arch/x86/include/asm/x86_64/efibind\\.h$"}
> +-file_tag+={adopted,"^xen/arch/arm/include/asm/arm64/efibind\\.h$"}
>  -doc_end
>  
>  -doc_begin="Build tools are out of scope."
> @@ -104,6 +105,10 @@
>  -file_tag+={out_of_scope,"^xen/include/xen/xxhash\\.h$"}
>  -doc_end
>  
> +-doc_begin="Out of scope code to support gcov."
> +-file_tag+={out_of_scope, "^xen/common/coverage/.*$"}
> +-doc_end
> +
>  -doc_begin="Headers under xen/include/public/ are the description of the public
>  hypercall ABI so the community is extremely conservative in making changes
>  there, because the interface is maintained for backward compatibility: ignore
> -- 
> 2.34.1
>