1. Patchew
  2. Xen
  3. View series

[XEN PATCH] automation/eclair_analysis: substitute deprecated service

Nicola Vetrini posted 1 patch 2 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/4850cedd9680e521cfac350930b24af19cdf1ab8.1713338908.git.nicola.vetrini@bugseng.com
automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Nicola Vetrini 2 weeks ago 
The service STD.emptrecd is in the process of being removed in favour
of STD.anonstct.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
 automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl b/automation/eclair_analysis/ECLAIR/toolchain.ecl
index 71a1e2cce029..86e9a79b5231 100644
--- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
+++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
@@ -44,8 +44,8 @@
 -doc_end
 
 -doc_begin="See Section \"6.19 Structures with No Members\" of "GCC_MANUAL"."
--config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
--config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
+-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
+-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
 -doc_end
 
 -doc_begin="See Section \"6.18 Arrays of Length Zero\" of "GCC_MANUAL"."
-- 
2.34.1
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Jan Beulich 1 week, 6 days ago 
On 17.04.2024 16:51, Nicola Vetrini wrote:
> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> @@ -44,8 +44,8 @@
>  -doc_end
>  
>  -doc_begin="See Section \"6.19 Structures with No Members\" of "GCC_MANUAL"."
> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>  -doc_end

I'm irritated by this, which may be in part because of too terse a description.
"emptrecd" looks like an abbreviation of "empty record" to me, in line with
"Structures with No Members". "anonstct" otoh looks an abbreviation of
"anonymous structures" to me, which is something different (structures without
names).

Jan
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Nicola Vetrini 1 week, 6 days ago 
On 2024-04-18 09:22, Jan Beulich wrote:
> On 17.04.2024 16:51, Nicola Vetrini wrote:
>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> @@ -44,8 +44,8 @@
>>  -doc_end
>> 
>>  -doc_begin="See Section \"6.19 Structures with No Members\" of 
>> "GCC_MANUAL"."
>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>  -doc_end
> 
> I'm irritated by this, which may be in part because of too terse a 
> description.
> "emptrecd" looks like an abbreviation of "empty record" to me, in line 
> with
> "Structures with No Members". "anonstct" otoh looks an abbreviation of
> "anonymous structures" to me, which is something different (structures 
> without
> names).
> 
> Jan

I'm afraid I can't do much about this. From a functionality standpoint 
there is no difference for Xen.

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Jan Beulich 1 week, 6 days ago 
On 18.04.2024 17:00, Nicola Vetrini wrote:
> On 2024-04-18 09:22, Jan Beulich wrote:
>> On 17.04.2024 16:51, Nicola Vetrini wrote:
>>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> @@ -44,8 +44,8 @@
>>>  -doc_end
>>>
>>>  -doc_begin="See Section \"6.19 Structures with No Members\" of 
>>> "GCC_MANUAL"."
>>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>>  -doc_end
>>
>> I'm irritated by this, which may be in part because of too terse a 
>> description.
>> "emptrecd" looks like an abbreviation of "empty record" to me, in line 
>> with
>> "Structures with No Members". "anonstct" otoh looks an abbreviation of
>> "anonymous structures" to me, which is something different (structures 
>> without
>> names).
> 
> I'm afraid I can't do much about this. From a functionality standpoint 
> there is no difference for Xen.

What I'm pretty sure you can do is provide a patch description that
allows readers to understand anything seemingly (or actually) anomalous.

Jan
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Nicola Vetrini 1 week, 6 days ago 
On 2024-04-18 17:15, Jan Beulich wrote:
> On 18.04.2024 17:00, Nicola Vetrini wrote:
>> On 2024-04-18 09:22, Jan Beulich wrote:
>>> On 17.04.2024 16:51, Nicola Vetrini wrote:
>>>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>>> @@ -44,8 +44,8 @@
>>>>  -doc_end
>>>> 
>>>>  -doc_begin="See Section \"6.19 Structures with No Members\" of
>>>> "GCC_MANUAL"."
>>>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>>>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>>>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>>>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>>>  -doc_end
>>> 
>>> I'm irritated by this, which may be in part because of too terse a
>>> description.
>>> "emptrecd" looks like an abbreviation of "empty record" to me, in 
>>> line
>>> with
>>> "Structures with No Members". "anonstct" otoh looks an abbreviation 
>>> of
>>> "anonymous structures" to me, which is something different 
>>> (structures
>>> without
>>> names).
>> 
>> I'm afraid I can't do much about this. From a functionality standpoint
>> there is no difference for Xen.
> 
> What I'm pretty sure you can do is provide a patch description that
> allows readers to understand anything seemingly (or actually) 
> anomalous.
> 
> Jan

Ok

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Julien Grall 2 weeks ago 
Hi Nicola,

On 17/04/2024 15:51, Nicola Vetrini wrote:
> The service STD.emptrecd is in the process of being removed in favour
> of STD.anonstct.

I am guessing this is not a new feature and the current ECLAIR version 
is supporting it?

Cheers,

> 
> No functional change.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> ---
>   automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> index 71a1e2cce029..86e9a79b5231 100644
> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
> @@ -44,8 +44,8 @@
>   -doc_end
>   
>   -doc_begin="See Section \"6.19 Structures with No Members\" of "GCC_MANUAL"."
> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>   -doc_end
>   
>   -doc_begin="See Section \"6.18 Arrays of Length Zero\" of "GCC_MANUAL"."

-- 
Julien Grall
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Nicola Vetrini 2 weeks ago 
On 2024-04-17 16:57, Julien Grall wrote:
> Hi Nicola,
> 
> On 17/04/2024 15:51, Nicola Vetrini wrote:
>> The service STD.emptrecd is in the process of being removed in favour
>> of STD.anonstct.
> 
> I am guessing this is not a new feature and the current ECLAIR version 
> is supporting it?
> 
> Cheers,
> 

Yes, it was just an oversight to leave the old emptrcd there. It will 
eventually be phased out in the next release.

>> 
>> No functional change.
>> 
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>> ---
>>   automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl 
>> b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> index 71a1e2cce029..86e9a79b5231 100644
>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>> @@ -44,8 +44,8 @@
>>   -doc_end
>>     -doc_begin="See Section \"6.19 Structures with No Members\" of 
>> "GCC_MANUAL"."
>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>   -doc_end
>>     -doc_begin="See Section \"6.18 Arrays of Length Zero\" of 
>> "GCC_MANUAL"."

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [XEN PATCH] automation/eclair_analysis: substitute deprecated service
Posted by Julien Grall 2 weeks ago 

On 17/04/2024 16:05, Nicola Vetrini wrote:
> On 2024-04-17 16:57, Julien Grall wrote:
>> Hi Nicola,
>>
>> On 17/04/2024 15:51, Nicola Vetrini wrote:
>>> The service STD.emptrecd is in the process of being removed in favour
>>> of STD.anonstct.
>>
>> I am guessing this is not a new feature and the current ECLAIR version 
>> is supporting it?
>>
>> Cheers,
>>
> 
> Yes, it was just an oversight to leave the old emptrcd there. It will 
> eventually be phased out in the next release.

Thanks for confirming!

I don't have a way to test ECLAIR or any knowledge. But if you need an ack:

Acked-by: Julien Grall <jgrall@amazon.com>

Cheers,


> 
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>>> ---
>>>   automation/eclair_analysis/ECLAIR/toolchain.ecl | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/automation/eclair_analysis/ECLAIR/toolchain.ecl 
>>> b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> index 71a1e2cce029..86e9a79b5231 100644
>>> --- a/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> +++ b/automation/eclair_analysis/ECLAIR/toolchain.ecl
>>> @@ -44,8 +44,8 @@
>>>   -doc_end
>>>     -doc_begin="See Section \"6.19 Structures with No Members\" of 
>>> "GCC_MANUAL"."
>>> --config=STD.emptrecd,behavior+={c99,GCC_ARM64,specified}
>>> --config=STD.emptrecd,behavior+={c99,GCC_X86_64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_ARM64,specified}
>>> +-config=STD.anonstct,behavior+={c99,GCC_X86_64,specified}
>>>   -doc_end
>>>     -doc_begin="See Section \"6.18 Arrays of Length Zero\" of 
>>> "GCC_MANUAL"."
> 

-- 
Julien Grall

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.