xen/events: fix error code in xen_bind_pirq_msi_to_irq()

[PATCH v2] xen/events: fix error code in xen_bind_pirq_msi_to_irq()

Dan Carpenter posted 1 patch 5 months, 1 week ago

Download mbox

Failed in applying to current master (apply log)

drivers/xen/events/events_base.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] xen/events: fix error code in xen_bind_pirq_msi_to_irq()

Posted by Dan Carpenter 5 months, 1 week ago

Return -ENOMEM if xen_irq_init() fails.  currently the code returns an
uninitialized variable or zero.

Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
v2: Part of v1 was bogus.  Delete that bit.

 drivers/xen/events/events_base.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c
index f5edb9e27e3c..b8cfea7812d6 100644
--- a/drivers/xen/events/events_base.c
+++ b/drivers/xen/events/events_base.c
@@ -1110,8 +1110,10 @@ int xen_bind_pirq_msi_to_irq(struct pci_dev *dev, struct msi_desc *msidesc,
 
 	for (i = 0; i < nvec; i++) {
 		info = xen_irq_init(irq + i);
-		if (!info)
+		if (!info) {
+			ret = -ENOMEM;
 			goto error_irq;
+		}
 
 		irq_set_chip_and_handler_name(irq + i, &xen_pirq_chip, handle_edge_irq, name);
 
-- 
2.42.0

Re: [PATCH v2] xen/events: fix error code in xen_bind_pirq_msi_to_irq()

Posted by Juergen Gross 5 months, 1 week ago

On 28.11.23 07:52, Dan Carpenter wrote:
> Return -ENOMEM if xen_irq_init() fails.  currently the code returns an
> uninitialized variable or zero.
> 
> Fixes: 5dd9ad32d775 ("xen/events: drop xen_allocate_irqs_dynamic()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Juergen Gross <jgross@ssue.com>


Juergen