x86: log non-responding CPUs in fatal_trap()

[PATCH] x86: log non-responding CPUs in fatal_trap()

Posted by Jan Beulich 1 year, 9 months ago

This eases recognizing that something odd is going on.

Signed-off-by: Jan Beulich <jbeulich@suse.com>

--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -845,6 +845,9 @@ void fatal_trap(const struct cpu_user_re
                     msecs = 10;
                 }
             }
+            if ( pending )
+                printk("Non-responding CPUs: %*pbl\n",
+                       CPUMASK_PR(&show_state_mask));
         }
     }

Re: [PATCH] x86: log non-responding CPUs in fatal_trap()

Posted by Andrew Cooper 1 year, 9 months ago

On 13/07/2022 07:51, Jan Beulich wrote:
> This eases recognizing that something odd is going on.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -845,6 +845,9 @@ void fatal_trap(const struct cpu_user_re
>                      msecs = 10;
>                  }
>              }
> +            if ( pending )
> +                printk("Non-responding CPUs: %*pbl\n",
> +                       CPUMASK_PR(&show_state_mask));

Prevailing style elsewhere is {%*pbl}.

Preferably with that adjusted, Acked-by: Andrew Cooper
<andrew.cooper3@citrix.com>