1. Patchew
  2. Xen
  3. View series

[XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines

Nicola Vetrini posted 1 patch 5 months, 3 weeks ago
Patches applied successfully (tree, apply log)
git fetch https://gitlab.com/xen-project/patchew/xen tags/patchew/3af20044d2906a6f873aac1b6dd2b41c5b9e0507.1717269049.git.nicola.vetrini@bugseng.com
automation/eclair_analysis/ECLAIR/tagging.ecl | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines
Posted by Nicola Vetrini 5 months, 3 weeks ago 
Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are added
to the list of clean guidelines.

Some guidelines listed in the additional clean section for ARM are also
clean on x86, so they can be removed from there.

No functional change.

Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
---
+Cc Oleksii for an opinion on the inclusion for 4.19

This is a follow-up to series
https://lore.kernel.org/xen-devel/cover.1717236930.git.nicola.vetrini@bugseng.com/
and depends on it (otherwise the gitlab MISRA analysis would fail on
violations of Rule 20.12).
If it is decided that the dependent series should go in for 4.19, then
my suggestion is to include this as well, to the gating on more
guidelines.
---
 automation/eclair_analysis/ECLAIR/tagging.ecl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl b/automation/eclair_analysis/ECLAIR/tagging.ecl
index a354ff322e03..b829655ca0bc 100644
--- a/automation/eclair_analysis/ECLAIR/tagging.ecl
+++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
@@ -60,6 +60,7 @@ MC3R1.R11.7||
 MC3R1.R11.9||
 MC3R1.R12.5||
 MC3R1.R14.1||
+MC3R1.R14.4||
 MC3R1.R16.7||
 MC3R1.R17.1||
 MC3R1.R17.3||
@@ -73,6 +74,7 @@ MC3R1.R20.4||
 MC3R1.R20.6||
 MC3R1.R20.9||
 MC3R1.R20.11||
+MC3R1.R20.12||
 MC3R1.R20.13||
 MC3R1.R20.14||
 MC3R1.R21.3||
@@ -105,7 +107,7 @@ if(string_equal(target,"x86_64"),
 )
 
 if(string_equal(target,"arm64"),
-    service_selector({"additional_clean_guidelines","MC3R1.R14.4||MC3R1.R16.6||MC3R1.R20.12||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.2||MC3R1.R7.3||MC3R1.R8.6||MC3R1.R9.3"})
+    service_selector({"additional_clean_guidelines","MC3R1.R16.6||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.3"})
 )
 
 -reports+={clean:added,"service(clean_guidelines_common||additional_clean_guidelines)"}
-- 
2.34.1
Re: [XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines
Posted by Oleksii K. 5 months, 3 weeks ago 
On Sat, 2024-06-01 at 21:13 +0200, Nicola Vetrini wrote:
> Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are
> added
> to the list of clean guidelines.
> 
> Some guidelines listed in the additional clean section for ARM are
> also
> clean on x86, so they can be removed from there.
> 
> No functional change.
> 
> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> ---
> +Cc Oleksii for an opinion on the inclusion for 4.19
> 
> This is a follow-up to series
> https://lore.kernel.org/xen-devel/cover.1717236930.git.nicola.vetrini@bugseng.com/
> and depends on it (otherwise the gitlab MISRA analysis would fail on
> violations of Rule 20.12).
> If it is decided that the dependent series should go in for 4.19,
> then
> my suggestion is to include this as well, to the gating on more
> guidelines.
> ---
I just want to clarify if I understand you correctly. Do you mean taht
the current one patch will be merged without dependent series that
gitlab MISRA analysis would fail? IIUUC then I am not sure that we have
an option to have this patch without the dependent patch series.

~ Oleksii
>  automation/eclair_analysis/ECLAIR/tagging.ecl | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl
> b/automation/eclair_analysis/ECLAIR/tagging.ecl
> index a354ff322e03..b829655ca0bc 100644
> --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
> +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
> @@ -60,6 +60,7 @@ MC3R1.R11.7||
>  MC3R1.R11.9||
>  MC3R1.R12.5||
>  MC3R1.R14.1||
> +MC3R1.R14.4||
>  MC3R1.R16.7||
>  MC3R1.R17.1||
>  MC3R1.R17.3||
> @@ -73,6 +74,7 @@ MC3R1.R20.4||
>  MC3R1.R20.6||
>  MC3R1.R20.9||
>  MC3R1.R20.11||
> +MC3R1.R20.12||
>  MC3R1.R20.13||
>  MC3R1.R20.14||
>  MC3R1.R21.3||
> @@ -105,7 +107,7 @@ if(string_equal(target,"x86_64"),
>  )
>  
>  if(string_equal(target,"arm64"),
> -   
> service_selector({"additional_clean_guidelines","MC3R1.R14.4||MC3R1.R
> 16.6||MC3R1.R20.12||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.2||MC3R1.R7.3||M
> C3R1.R8.6||MC3R1.R9.3"})
> +   
> service_selector({"additional_clean_guidelines","MC3R1.R16.6||MC3R1.R
> 2.1||MC3R1.R5.3||MC3R1.R7.3"})
>  )
>  
>  -
> reports+={clean:added,"service(clean_guidelines_common||additional_cl
> ean_guidelines)"}
Re: [XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines
Posted by Nicola Vetrini 5 months, 3 weeks ago 
On 2024-06-04 13:39, Oleksii K. wrote:
> On Sat, 2024-06-01 at 21:13 +0200, Nicola Vetrini wrote:
>> Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they are
>> added
>> to the list of clean guidelines.
>> 
>> Some guidelines listed in the additional clean section for ARM are
>> also
>> clean on x86, so they can be removed from there.
>> 
>> No functional change.
>> 
>> Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
>> ---
>> +Cc Oleksii for an opinion on the inclusion for 4.19
>> 
>> This is a follow-up to series
>> https://lore.kernel.org/xen-devel/cover.1717236930.git.nicola.vetrini@bugseng.com/
>> and depends on it (otherwise the gitlab MISRA analysis would fail on
>> violations of Rule 20.12).
>> If it is decided that the dependent series should go in for 4.19,
>> then
>> my suggestion is to include this as well, to the gating on more
>> guidelines.
>> ---
> I just want to clarify if I understand you correctly. Do you mean taht
> the current one patch will be merged without dependent series that
> gitlab MISRA analysis would fail? IIUUC then I am not sure that we have
> an option to have this patch without the dependent patch series.
> 

Exactly, that's why I specified the dependency. This patch should have 
been part of the series, but I forgot to include it.

> ~ Oleksii
>>  automation/eclair_analysis/ECLAIR/tagging.ecl | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl
>> b/automation/eclair_analysis/ECLAIR/tagging.ecl
>> index a354ff322e03..b829655ca0bc 100644
>> --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
>> +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
>> @@ -60,6 +60,7 @@ MC3R1.R11.7||
>>  MC3R1.R11.9||
>>  MC3R1.R12.5||
>>  MC3R1.R14.1||
>> +MC3R1.R14.4||
>>  MC3R1.R16.7||
>>  MC3R1.R17.1||
>>  MC3R1.R17.3||
>> @@ -73,6 +74,7 @@ MC3R1.R20.4||
>>  MC3R1.R20.6||
>>  MC3R1.R20.9||
>>  MC3R1.R20.11||
>> +MC3R1.R20.12||
>>  MC3R1.R20.13||
>>  MC3R1.R20.14||
>>  MC3R1.R21.3||
>> @@ -105,7 +107,7 @@ if(string_equal(target,"x86_64"),
>>  )
>>  
>>  if(string_equal(target,"arm64"),
>> -   
>> service_selector({"additional_clean_guidelines","MC3R1.R14.4||MC3R1.R
>> 16.6||MC3R1.R20.12||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.2||MC3R1.R7.3||M
>> C3R1.R8.6||MC3R1.R9.3"})
>> +   
>> service_selector({"additional_clean_guidelines","MC3R1.R16.6||MC3R1.R
>> 2.1||MC3R1.R5.3||MC3R1.R7.3"})
>>  )
>>  
>>  -
>> reports+={clean:added,"service(clean_guidelines_common||additional_cl
>> ean_guidelines)"}

-- 
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)
Re: [XEN PATCH] automation/eclair_analysis: add more clean MISRA guidelines
Posted by Oleksii K. 5 months, 3 weeks ago 
On Tue, 2024-06-04 at 14:01 +0200, Nicola Vetrini wrote:
> On 2024-06-04 13:39, Oleksii K. wrote:
> > On Sat, 2024-06-01 at 21:13 +0200, Nicola Vetrini wrote:
> > > Rules 20.9, 20.12 and 14.4 are now clean on ARM and x86, so they
> > > are
> > > added
> > > to the list of clean guidelines.
> > > 
> > > Some guidelines listed in the additional clean section for ARM
> > > are
> > > also
> > > clean on x86, so they can be removed from there.
> > > 
> > > No functional change.
> > > 
> > > Signed-off-by: Nicola Vetrini <nicola.vetrini@bugseng.com>
> > > ---
> > > +Cc Oleksii for an opinion on the inclusion for 4.19
> > > 
> > > This is a follow-up to series
> > > https://lore.kernel.org/xen-devel/cover.1717236930.git.nicola.vetrini@bugseng.com/
> > > and depends on it (otherwise the gitlab MISRA analysis would fail
> > > on
> > > violations of Rule 20.12).
> > > If it is decided that the dependent series should go in for 4.19,
> > > then
> > > my suggestion is to include this as well, to the gating on more
> > > guidelines.
> > > ---
> > I just want to clarify if I understand you correctly. Do you mean
> > taht
> > the current one patch will be merged without dependent series that
> > gitlab MISRA analysis would fail? IIUUC then I am not sure that we
> > have
> > an option to have this patch without the dependent patch series.
> > 
> 
> Exactly, that's why I specified the dependency. This patch should
> have 
> been part of the series, but I forgot to include it.
I am okay to consider this patches in Xen 4.19, but only in case it the
dependencies will be resolved properly and necessary Acked will be
recieved.

~ Oleksii
> 
> > ~ Oleksii
> > >  automation/eclair_analysis/ECLAIR/tagging.ecl | 4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/automation/eclair_analysis/ECLAIR/tagging.ecl
> > > b/automation/eclair_analysis/ECLAIR/tagging.ecl
> > > index a354ff322e03..b829655ca0bc 100644
> > > --- a/automation/eclair_analysis/ECLAIR/tagging.ecl
> > > +++ b/automation/eclair_analysis/ECLAIR/tagging.ecl
> > > @@ -60,6 +60,7 @@ MC3R1.R11.7||
> > >  MC3R1.R11.9||
> > >  MC3R1.R12.5||
> > >  MC3R1.R14.1||
> > > +MC3R1.R14.4||
> > >  MC3R1.R16.7||
> > >  MC3R1.R17.1||
> > >  MC3R1.R17.3||
> > > @@ -73,6 +74,7 @@ MC3R1.R20.4||
> > >  MC3R1.R20.6||
> > >  MC3R1.R20.9||
> > >  MC3R1.R20.11||
> > > +MC3R1.R20.12||
> > >  MC3R1.R20.13||
> > >  MC3R1.R20.14||
> > >  MC3R1.R21.3||
> > > @@ -105,7 +107,7 @@ if(string_equal(target,"x86_64"),
> > >  )
> > >  
> > >  if(string_equal(target,"arm64"),
> > > -   
> > > service_selector({"additional_clean_guidelines","MC3R1.R14.4||MC3
> > > R1.R
> > > 16.6||MC3R1.R20.12||MC3R1.R2.1||MC3R1.R5.3||MC3R1.R7.2||MC3R1.R7.
> > > 3||M
> > > C3R1.R8.6||MC3R1.R9.3"})
> > > +   
> > > service_selector({"additional_clean_guidelines","MC3R1.R16.6||MC3
> > > R1.R
> > > 2.1||MC3R1.R5.3||MC3R1.R7.3"})
> > >  )
> > >  
> > >  -
> > > reports+={clean:added,"service(clean_guidelines_common||additiona
> > > l_cl
> > > ean_guidelines)"}
>

Patchew 2.1-devel-b67e4c2

© 2016 - 2024 Red Hat, Inc.